xfs
[Top] [All Lists]

Re: [patch 1/2] Laptop mode support for XFS

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 1/2] Laptop mode support for XFS
From: Bart Samwel <bart@xxxxxxxxx>
Date: Fri, 02 Apr 2004 11:44:47 +0200
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20040402103333.A787@infradead.org>
References: <E1B9KzA-00083v-Is@samwel.tk> <20040402103333.A787@infradead.org>
Sender: linux-xfs-bounce@xxxxxxxxxxx
On Fri, 2004-04-02 at 11:33, Christoph Hellwig wrote:
> On Fri, Apr 02, 2004 at 11:29:11AM +0200, bart@xxxxxxxxx wrote:
> > 
> > From: Bart Samwel <bart@xxxxxxxxx>
> > 
> > Add laptop mode support for XFS.
> > 
> > * Add /proc/sys/fs/xfs/lm_age_buffer and .../lm_flush_interval, values that
> >   are used instead of age_buffer and flush_interval when laptop mode is
> >   active.
> 
> This doesn't make sense.  Just change those values from userspace if your
> 'laptop mode' is active.

The maximums that are listed for the regular flush_interval and
age_buffer are way too low for laptop mode usage. I've considered
increasing the maximums, but I figured they would be that low for a
reason. By doing it this way, the maximums for regular usage aren't
affected. If everybody thinks it's OK to simply increase the maximums on
the regular ones to INT_MAX (or at least something like HZ*7200), I'll
_gladly_ do that instead.

--Bart


<Prev in Thread] Current Thread [Next in Thread>