Greg - Ethan's is more correct, don't worry about consistency. Either
is fine.
A couple other suggestions: (did you know what you were signing up for
here?) :)
Rather than using SCRATCH_DEV for the LVM tests, we probably would need
a new SCRATCH_LVM_DEV since they need to be different partition types.
I doubt that we want to try to change partition types on the fly. :)
Also, if you want to use something other than "dd" to generate fs
activity, you could use something like fsstress, which is part of the
xfstest suite.
-Eric
On Fri, 2002-08-30 at 16:19, Greg Freemyer wrote:
>
> >> > tmp=/tmp/$$
>
> >> very predictable, use tmp=`mktemp -d` || exit 1
>
> Someone with SGI,
>
> Ethan has recommended the above change to my script. It is easy enough to
> do. As a matter of fact I have already done it.
>
> Every other script in xfstests uses the tmp=/tmp/$$ as a prefix for temp
> files.
>
> Ethan's recommendation is to use a unique directory and place temporary files
> in the directory.
>
> I can see where Ethan's suggestion is better, but for consistency sake it may
> be better to put it back the way it was.
>
> Please advise.
>
> Greg
>
--
Eric Sandeen XFS for Linux http://oss.sgi.com/projects/xfs
sandeen@xxxxxxx SGI, Inc. 651-683-3102
|