On Tue, 2002-06-18 at 21:14, Keith Owens wrote:
> On 18 Jun 2002 09:35:58 -0500,
> Steve Lord <lord@xxxxxxx> wrote:
> >This is the program to fix up the files left behind by this bug. It
> >does a tree walk of a directory and mmaps files looking for candidates,
> >if it finds a file with space in the last block beyond end of file
> >which has non-zero data in it, it will zero the remainder of the
> >block.
>
> Due to a unrelated kernel (not XFS) bug, the program may or may not
> change the timestamp on the files. Updating an mmapped file without
> doing an explicit write to the file is not guaranteed to change the
> timestamp, files can be changed but appear unchanged. This kernel bug
> messes up rsync --newer, backups and any other programs that rely on
> the timestamp.
>
> Also 4096 should be getpagesize() to cater for IA64.
The program was put together quickly and could be better, if someone
wants to clean it up that would be good (i.e. prevent it from walking
into non-xfs filesystems etc).
I would actually say we do not want to update the timestamps here, we
are trying to fix the problems in the filesystem here, and not modify
the metadata.
Steve
|