xfs
[Top] [All Lists]

Re: [PATCH] (repost) kmem_cache_zalloc

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] (repost) kmem_cache_zalloc
From: Steve Lord <lord@xxxxxxx>
Date: 25 Apr 2002 08:38:00 -0500
Cc: Eric Sandeen <sandeen@xxxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: <20020425101333.A18583@infradead.org>
References: <1019682472.15455.33.camel@stout.americas.sgi.com> <20020425101333.A18583@infradead.org>
Sender: owner-linux-xfs@xxxxxxxxxxx
On Thu, 2002-04-25 at 04:13, Christoph Hellwig wrote:
> On Wed, Apr 24, 2002 at 04:07:52PM -0500, Eric Sandeen wrote:
> > We'd like to incorporate this into the kernel proper, and several others
> > chimed in that it would be useful, so here's the patch.  If it's a no-go
> > with Linus, we can roll this functionality back under fs/xfs to reduce
> > our changes in the mainline kernel.
> 
> What about getting rid of it completly instead?
> 
> There are only two callers, one is in the pagebuf code and would benefit
> from letting slab cache initialized objects and the other in the emulation
> of IRIX's kmen_zone_zalloc..

It is a little more complex than those two places - they do not know
how big the memory is, that is hidden in the zone itself - which is
not accessible outside slab.c. You need to go back to the callers of
kmem_zone_zalloc and do the work there. Actually there are only 19
of them, so it is not too bad.

Steve

-- 

Steve Lord                                      voice: +1-651-683-3511
Principal Engineer, Filesystem Software         email: lord@xxxxxxx


<Prev in Thread] Current Thread [Next in Thread>