hi Chris,
On Jul 17, 3:19pm, Chris Bednar wrote:
> Subject: am-utils xfs PATCH
>
> Hi
>
> The following are (1) a patch to am-utils-6.0.5 (a la
> RedHat 7.1) to get it to build on a system with XFS installed,
> and (2) a spec file for RPM with configure options to go with
> the patch.
>
> This is pretty kludgy, but it does work... it basically just
> adds an #include <xfs/libxfs.h> to amd/ops_xfs.c and adds
>
> --enable-am-cflags="-I/usr/include/xfs -Dxfs_args_t=xfs_da_args_t"
>
> to the configure. It's cheap and dirty, but it works.
This doesn't look quite right - the xfs_args struct in IRIX
is used to pass the mount arguments across the mount syscall
interface (as binary data), but in Linux each filesystem's
options are passed in as a comma separated list (a string of
characters).
xfs_da_args_t is something unrelated to mount(2), and is only
for use within the kernel and libxfs. In general, you don't
want to be #include'ing files from /usr/include/xfs/* at all.
The right way to implement this would be to figure out how the
other Linux filesystems are handled and do XFS (Linux/XFS, that
is) the same way, then make the existing amd code for XFS only
be used on IRIX. I've only had a quick look at the am-utils
code just now, so can't really give you more advice than that,
I'm afraid.
cheers.
--
Nathan
|