Re: xfs_fsr for linux

["Nathan Scott" <nathans@xxxxxxxxxxxxxxxxxxxxxxxx>]

hi Bill,

On Jul 20,  2:24am, William L. Jones wrote:
> Subject: xfs_fsr for linux
> 
> Nathan,
> 
> I made some progress on xfs until I hit a problem with XFS_IOC_OPEN_BY_HANDLE
> ioctl.  I am getting kern fault when I try to open a file by its handle.
> 
> In xfs_open_by_handle. linux/fs/xfs/linux/xfs_ioctl.c, I found the
> following bit of code:
> 
> 
>           /*
>           * Make a unique name for dcache.
>           */
>          cpi = (char *)hanp;
>          cpo = sname;
> 
> 
> hanp is an address to the handle in user space.  It may not point to a
> valid kernal address.    I think that intent was to use the file handle id
> as a file name.
> 
> 
> Could you look at the code a see what you think.
> 

hmmm - yes, from the quick look I had, I'd say you're right.
I think Ted wrote/ported this code originally - let me pass
this off to him to delve into.

thanks.

-- 
Nathan