| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, axboe@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size |
| From: | Hannes Reinecke <hare@xxxxxxx> |
| Date: | Thu, 29 Sep 2016 07:56:31 +0200 |
| Cc: | linux-block@xxxxxxxxxxxxxxx, tytso@xxxxxxx, martin.petersen@xxxxxxxxxx, snitzer@xxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, bfoster@xxxxxxxxxx, xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, bart.vanassche@xxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <147510958448.8940.14280630935441533825.stgit@xxxxxxxxxxxxxxxx> |
| References: | <147510957066.8940.13803086684642725401.stgit@xxxxxxxxxxxxxxxx> <147510958448.8940.14280630935441533825.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/29/2016 02:39 AM, Darrick J. Wong wrote: > Make sure that the offset and length arguments that we're using to > construct WRITE SAME and DISCARD requests are actually aligned to the > logical block size. Failure to do this causes other errors in other > parts of the block layer or the SCSI layer because disks don't support > partial logical block writes. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> > Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> > --- > block/blk-lib.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg GF: J. Hawn, J. Guild, F. ImendÃrffer, HRB 16746 (AG NÃrnberg) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Hannes Reinecke |
|---|---|
| Next by Date: | Re: [PATCH 3/3] block: implement (some of) fallocate for block devices, Hannes Reinecke |
| Previous by Thread: | [PATCH 2/3] block: require write_same and discard requests align to logical block size, Darrick J. Wong |
| Next by Thread: | [PATCH 3/3] block: implement (some of) fallocate for block devices, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |