stp
[Top] [All Lists]

Small patch for 0.33

To: stp@xxxxxxxxxxx
Subject: Small patch for 0.33
From: Pekka Pietikainen <Pekka.Pietikainen@xxxxxxx>
Date: Fri, 23 Mar 2001 15:27:38 +0100 (CET)
Sender: owner-stp@xxxxxxxxxxx
Oops, after some data integrity testing I noticed that the new code
using the 2.4 zero-copy stuff didn't work for packets coming from
anything else but page boundaries. Patch below should fix that problem.

There also seems to be a firmware bug, occasionally it
returns garbage instead of the packet it should be getting.
At least it seems to be returning the same garbage every time
at more or less consistant intervals, so it's probably not link 
errors causing the problem. I'll try to track it down next week (firmware
debugging is _so_ much fun :/)
Without firmware acceleration things seem to be fine...

--- /usr/src/stp2/linux/net/stp/stvd/stvd_encap.c       Fri Mar 23 15:14:14 2001
+++ stvd_encap.c        Fri Mar 23 15:16:13 2001
@@ -169,7 +169,7 @@
                 */
                get_page(virt_to_page(daddr));
                 skb_shinfo(skb)->frags[0].page=virt_to_page(daddr);
-                skb_shinfo(skb)->frags[0].page_offset = 0;
+                skb_shinfo(skb)->frags[0].page_offset = (u32)daddr % PAGE_SIZE;
                 skb_shinfo(skb)->frags[0].size = this_stusize;
                 skb_shinfo(skb)->nr_frags = 1;
                 skb->len+=this_stusize;


<Prev in Thread] Current Thread [Next in Thread>
  • Small patch for 0.33, Pekka Pietikainen <=