pcp
[Top] [All Lists]

Re: sosreport and pcp

To: Michele Baldessari <michele@xxxxxxxxxx>
Subject: Re: sosreport and pcp
From: fche@xxxxxxxxxx (Frank Ch. Eigler)
Date: Thu, 01 May 2014 16:56:05 -0400
Cc: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <20140501200341.GA23705@xxxxxxxxxxxxxxx> (Michele Baldessari's message of "Thu, 1 May 2014 21:03:41 +0100")
References: <20140429141502.GD15985@xxxxxxxxxxxxxxx> <y0mzjj4j5pp.fsf@xxxxxxxx> <53601960.5000503@xxxxxxxxxxxxxxxx> <20140501200341.GA23705@xxxxxxxxxxxxxxx>
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)
Hi, Michele -

> [...]
> Code is here:
> https://github.com/mbaldessari/sosreport/tree/pcp-plugin

More specifically here:

https://github.com/mbaldessari/sosreport/blob/pcp-plugin/sos/plugins/pcp.py

Looks good.  Unless I misread, it looks like it adds only the
archives and some of the named files from kenj's list.  It'd be
nice if the script also added more general wildcardy patterns
such as:

        self.add_copy_spec(os.path.join(self.pcp_log_dir, '*/*.log*'))
        self.add_copy_spec(os.path.join(self.pcp_log_dir, '*/*/*.log*'))
        self.add_copy_spec(os.path.join(self.pcp_log_dir, '*/*/config*'))

to catch as many error-log / generated-config files as possible.
These are small and useful for diagnostics.


- FChE

<Prev in Thread] Current Thread [Next in Thread>