pcp
[Top] [All Lists]

Re: memory corruption bug fix, libpcp p_instance.c

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: memory corruption bug fix, libpcp p_instance.c
From: fche@xxxxxxxxxx (Frank Ch. Eigler)
Date: Fri, 06 Mar 2015 13:00:58 -0500
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <54F8B1EC.4050501@xxxxxxxxxxxxxxxx> (Ken McDonell's message of "Fri, 06 Mar 2015 06:43:40 +1100")
References: <20150302235142.GG21203@xxxxxxxxxx> <54F8B1EC.4050501@xxxxxxxxxxxxxxxx>
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)
Ken McDonell <kenj@xxxxxxxxxxxxxxxx> writes:

> [...]
>> valgrind pmval 'pmcd.buf.alloc' -i \
>>    `awk 'BEGIN { for (i=0;i<3000;i++) { printf "x" }; printf("\n"); }'`
>
> This is a classical example of where a unit test should _not_ be
> added to an existing test, rather a new test should be created.  If
> we added it to an existing test that would fail until the code fix
> is applied [...]

OK (though in this case the code fix came at the same time).


> [...]
> Making a new test is so simple ...

Ah, neat, and it's mentioned in qa/README already.


- FChE

<Prev in Thread] Current Thread [Next in Thread>