Re: patch pcp-gui fix pmchart view save dialog

[fche@xxxxxxxxxx (Frank Ch. Eigler)]

Mark Goodwin <goodwinos@xxxxxxxxx> writes:

> The pmchart view save dialog uses the wrong pointer value
> when saving a view for metrics with a singular instance
> domain.

My earlier ("Quite") patch fixes this more properly.  Can someone
review/merge it please?

>       saveInsts = cp->metric(m)->explicitInsts();
> +        p = (char *)(const char *)cp->name(m).toAscii();
>       if (saveInsts) {
> -         p = (char *)(const char *)cp->name(m).toAscii();

Constructs of this form are not valid, as the toAscii object
goes out of scope, making the p pointer invalid.

- FChE