Re: First Cut at Avahi Support for PCP Servers

[fche@xxxxxxxxxx (Frank Ch. Eigler)]

Hi, Dave -

> I wanted to run this past you all for comments before committing or
> pushing anything. It's code that enables PCP server's to announce
> themselves over the local network using Avahi, if available.

Great start!

I have only a whitespace nit (a lot of the lines seem unnecessarily
wide) and this observatioN


> @@ -961,6 +965,11 @@ main(int argc, char *argv[])
>      __pmServerDumpRequestPorts(stderr);
>      fflush(stderr);
>  
> +    /* Advertise our presence on the network. */
> +    serverPresence = __pmServerAdvertisePresence(SERVER_SERVICE_NAME,
> +                                              SERVER_SERVICE_TAG,
> +                                              SERVER_PORT);
> +

Doing this in pmcd's main() is not ideal.  $SERVER_PORT can be easily
overridden by this time.  We'd want the actual port numbers used for
ipv4 (and separately, ipv6!) listening announced.


- FChE