pcp
[Top] [All Lists]

Re: pmServiceDiscoveryInterrupt() commit a8b87e2 et al.

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: pmServiceDiscoveryInterrupt() commit a8b87e2 et al.
From: fche@xxxxxxxxxx (Frank Ch. Eigler)
Date: Mon, 30 Jun 2014 06:31:53 -0400
Cc: Dave Brolley <brolley@xxxxxxxxxx>, pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1374649635.181830.1404090114319.JavaMail.zimbra@xxxxxxxxxx> (Nathan Scott's message of "Sun, 29 Jun 2014 21:01:54 -0400 (EDT)")
References: <20140619194444.3B03D58015@xxxxxxxx> <53AB0F27.602@xxxxxxxxxx> <1063089485.33910956.1403758262805.JavaMail.zimbra@xxxxxxxxxx> <53AC35B8.3000802@xxxxxxxxxx> <1193390011.34470957.1403829231937.JavaMail.zimbra@xxxxxxxxxx> <1374649635.181830.1404090114319.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)
Nathan Scott <nathans@xxxxxxxxxx> writes:

> typedef struct {
>     int         version;
>     int         interrupted;      /* could become a flags bitfield? */
>     const char  *globalOptions;   /* and this could be more explicit, */
> } pmDiscoveryOptions;

FWIW, since the abi comes to include the version# in the field, it is
IMHO a little worse than just putting the version number right into
the function name.  At least with that approach, we would have proper
type checking by the compiler for each version.  That's something lacking
in version-tagged structs -- and a hassle with e.g. the pmda structure.

- FChE

<Prev in Thread] Current Thread [Next in Thread>