Re: Python code vs local: host connections

[fche@xxxxxxxxxx (Frank Ch. Eigler)]

Nathan Scott <nathans@xxxxxxxxxx> writes:

> [...]

It looks good to me, except:

> -    def pmGetContextHostName( self ):
> +    def pmGetContextHostName(self):
> [...]
> -        status = LIBPCP.pmGetContextHostName(self.ctx)
> -        if status < 0:
> -            raise pmErr, status
> +        hp = c_char_p()
> +        hp = LIBPCP.pmGetContextHostName(self.ctx)
> +        hostname = hp
> +        LIBC.free(hp)
>          return status

While the new implementation of pmGetContextHostName does a strdup,
it's not documented to do that.  (For that matter, strdup could return
NULL, which we don't handle at all.)  I'm not sure we'd like to
instill that change in clients, by having them start to LIBC.free()
the result.  Or do we?  Maybe old clients would leak, but new ones
(running against the new libpcp.so only?) could free() the leak.

- FChE