Re: fetchgroups api - python bindings

[fche@xxxxxxxxxx (Frank Ch. Eigler)]

Hi, Marko -

Thanks for the reviews!

>> v = pmfg.extend_item("hinv.ncpu", c_api.PM_TYPE_U32)
>> vv = pmfg.extend_indom("kernel.all.load", c_api.PM_TYPE_FLOAT)
>
> - I mentioned about this earlier relating to the C API but I think it's
> worth checking again with the Python side: has the type argument really
> be mandatory here? If the user don't pass it, it'd require two lines to
> figure it out in the Python layer on the user's behalf and the user can
> later on do type(v()) or str(v()) or such as needed. [...]

You've got a pretty good case with python, since it's so dynamically
typed already.  OK, will accept None.


> - Regardless of the above, perhaps it might be better to define
> extend_item(self, metric=None, mtype=None, scale=None, instance=None)
> instead of
> extend_item(self, metric=None, mtype=None, instance=None, scale=None)

You're right.


- FChE