pcp
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [performancecopilot/speed] code review: add case int; TypeSwitchGuar

from [Suyash] [Permanent Link][Original]
To: performancecopilot/speed <speed@xxxxxxxxxxxxxxxxxx>
Subject: Re: [performancecopilot/speed] code review: add case int; TypeSwitchGuard short variable declaration (#14)
From: Suyash <notifications@xxxxxxxxxx>
Date: Mon, 18 Jul 2016 08:44:35 -0700
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1468856675; bh=EcFs90HvKGvkbedumog0LXd56ncxvzpOq39PnX3OruE=; h=From:Reply-To:To:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=u+R5Q/ZAHVElPDX5E8EhPW/iGs2TQBqGCClAKmLRen5vTZTQHSVXdnKe8kpewJiFu LkjI0ZREO98Ho4S97RVewkH706uN1zCme+XvVjVkoHp8VSth7e8oS9yb5f/10eTFUZ 25qaj05Mz1gfpDCOP8rkPMpb71tFf6OGLklaRI+k=
In-reply-to: <performancecopilot/speed/pull/14@xxxxxxxxxx>
List-archive: https://github.com/performancecopilot/speed
List-id: performancecopilot/speed <speed.performancecopilot.github.com>
List-post: <mailto:reply+00bd08b6c87d5b890257b67f6eb25f71b49fc41c1a8b9d3392cf0000000113a4bb6392a169ce09e6b644@reply.github.com>
List-unsubscribe: <mailto:unsub+00bd08b6c87d5b890257b67f6eb25f71b49fc41c1a8b9d3392cf0000000113a4bb6392a169ce09e6b644@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0IthZDXPmK96noXliMWH7G9JcoQT1Sks5qW59jgaJpZM4JOzgr>
References: <performancecopilot/speed/pull/14@xxxxxxxxxx>
Reply-to: performancecopilot/speed <reply+00bd08b6c87d5b890257b67f6eb25f71b49fc41c1a8b9d3392cf0000000113a4bb6392a169ce09e6b644@xxxxxxxxxxxxxxxx>

A couple of things

  1. We will never write int, the resolveInt function takes care of resolving int to one of int32, int64, uint32 and uint64, and that is kind of what we are going for, it removes any ambiguity related to the type, if you specified the MetricType as Uint32Type, the only value you can get is uint32, not uint or int. The rest is upto the user.

  2. Please always submit pull requests after rebasing with the latest upstream. The commit Merge pull request #1 from performancecopilot/master looks odd in the git history. Just add an upstream remote as the https address to this repository, pull to master and rebase your branch to it before submitting the PR.

But thanks for the general idea, looks cool ð

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [performancecopilot/speed] rename Writer to Client (#15), Suyash
Next by Date:  [performancecopilot/speed] use pkg/errors to create errors with contexts (#16), Suyash
Previous by Thread:  Re: [performancecopilot/speed] code review: add case int; TypeSwitchGuard short variable declaration (#14), Coveralls
Next by Thread:  [performancecopilot/speed] rename Writer to Client (#15), Suyash
Indexes:  [Date] [Thread] [Top] [All Lists]