pcp
[Top] [All Lists]

[performancecopilot/speed] rename Writer to Client (#15)

To: performancecopilot/speed <speed@xxxxxxxxxxxxxxxxxx>
Subject: [performancecopilot/speed] rename Writer to Client (#15)
From: Suyash <notifications@xxxxxxxxxx>
Date: Mon, 18 Jul 2016 08:34:03 -0700
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1468856043; bh=bqBlzEfEaHOXAe/6BsW/RhRzDd4GOvwsp8Ay6qfU/ek=; h=From:Reply-To:To:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=Ss4vgKAM6DO6mhR4kYUFkgWLnWl0HiyOGTA8xazQtiMbAL2U1u+7tjv132QVHrJ3q isq6Svva/PYvEQhAhAybLddhnnByEdvEqkBmfruR/Vi9jTZQWjoYI0LRx3pVcpm0lg cdkxmIgZEDYHXKW5WpW6yjpjpuUyErmgHJCRMDKM=
List-archive: https://github.com/performancecopilot/speed
List-id: performancecopilot/speed <speed.performancecopilot.github.com>
List-post: <mailto:reply+00bd08b63f64858587938fc43f2fc66c3d8cd6c49eab577192cf0000000113a4b8eb92a169ce09e6d580@reply.github.com>
List-unsubscribe: <mailto:unsub+00bd08b63f64858587938fc43f2fc66c3d8cd6c49eab577192cf0000000113a4b8eb92a169ce09e6d580@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0Itpe_QQOv4D6RqwMzRZnLKYLLuLeuks5qW5zrgaJpZM4JO1tg>
Reply-to: performancecopilot/speed <reply+00bd08b63f64858587938fc43f2fc66c3d8cd6c49eab577192cf0000000113a4b8eb92a169ce09e6d580@xxxxxxxxxxxxxxxx>

The fundamental reason for doing this is that the name writer in the golang community implies to most that the type implements io.Writer, and initially it did, but later on all the writing capability was abstracted away into bytebuffer, and the Buffer type does implement io.Writer, but speed.Writer doesn't, and I don't think the name is apt anymore. Looking at the current definition of the interface, I think Client is a more appropriate name, and will probably create less confusion.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<Prev in Thread] Current Thread [Next in Thread>
  • [performancecopilot/speed] rename Writer to Client (#15), Suyash <=