|
Looks good Ryan, thanks. I've pulled your commit into my tree and it will flow back to github via pcp.io in due course. This is a pretty unlikely code path (calling pmGetArchiveLabel() when the current context is valid, but not an archive) and I would expect none of our code can actually be persuaded to do this, so I am curious if you actually observed the problem that this patch fixes, or noticed by code inspection, or have some devious test harness and lock audit tool that exposed the logic error. Anyway, thanks for improving the correctness and robustness of the code. — |