|
This patch makes it actually possible to run PCP on Windows platform by cross-compiling from Fedora with mingw64. 1 - The format specifier for printing 64-bit signed and unsigned numbers is incorrect for Windows platform. It should be %I64d and %I64u as opposed to %lld and %llu. 2 - The MinGW on Windows already correctly defines the macros S_IRGRP, S_IWGRP, S_IROTH, S_IWOTH, S_IRWXG, and S_IRWXO but the current code incorrectly redefines all of them to 0 (zero). 3 - The current code tries to use Unix Domain Sockets for IPC communication with plugins. This is not supported on Windows platform. 4 - Fixed a SIGSEGV which happened when an error returned from setting up signal handlers. Instead of comparing the return to NULL it compared to < 0, which is a classic arithmetic to pointer comparison error. 5 - Fixed a bug of error handling when dynamic loading a shared library (DLL in case of Windows). You can view, comment on, or merge this pull request online at:https://github.com/performancecopilot/pcp/pull/34 Commit Summary
File Changes
Patch Links:
— |