pcp
[Top] [All Lists]

Re: [performancecopilot/pcp] logportmap.c:413]: (style) Suspicious condi

To: performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx>
Subject: Re: [performancecopilot/pcp] logportmap.c:413]: (style) Suspicious condition (#93)
From: Ken McDonell <notifications@xxxxxxxxxx>
Date: Sun, 15 May 2016 16:14:37 -0700
Cc:
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1463354077; bh=4OovphVD1ja3gcT85bzXgUE2LRJv8UBBjWjVPM8UIvA=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=KgPaXNvTGwliNExMf2woWHuN3R+pJD4XvJFwc69p9OnISbWPaQxViWJB3gv39HRWM D02O99CARtjg4UNC/y7iw4AHKSbFMbHPmrwtb+bh9AXL/7HIuIDd9QUUcCFuYpXnDe k6CXXu1kfiuCwccRPLj0SrKlBoAdB3KN4kp66WIE=
In-reply-to: <performancecopilot/pcp/issues/93@xxxxxxxxxx>
List-archive: https://github.com/performancecopilot/pcp
List-id: performancecopilot/pcp <pcp.performancecopilot.github.com>
List-post: <mailto:reply+00bd08b60b1ca6625dcb0c5e98874ccd7f8613a2dfd6800592cf000000011350c4dd92a169ce093ac9ea@reply.github.com>
List-unsubscribe: <mailto:unsub+00bd08b60b1ca6625dcb0c5e98874ccd7f8613a2dfd6800592cf000000011350c4dd92a169ce093ac9ea@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0IttK2v79EMxaT9ri-08Y5nyt8nL5Pks5qB6jdgaJpZM4IelFK>
References: <performancecopilot/pcp/issues/93@xxxxxxxxxx>
Reply-to: performancecopilot/pcp <reply+00bd08b60b1ca6625dcb0c5e98874ccd7f8613a2dfd6800592cf000000011350c4dd92a169ce093ac9ea@xxxxxxxxxxxxxxxx>

OK Frank ... the util.c one also means I should first free names[j] ... 0<=j<n-1 and then free names ... but this is a bit Nero-like in as much as the inner malloc() failing probably means the sky is about to fall in, so tossing a few bytes back into the pool probably won't prevent the end of the world.

The logutil.c one is legit, I agree.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

<Prev in Thread] Current Thread [Next in Thread>