|
The util.c:1796 memory leak seems legit; if names = realloc() succeeds but the [n-1]=malloc() fails, then names[] is unfreed. Similarly, logutil.c:1516, that error could result in pr being unfreed. — |
| To: | performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [performancecopilot/pcp] logportmap.c:413]: (style) Suspicious condition (#93) |
| From: | "Frank Ch. Eigler" <notifications@xxxxxxxxxx> |
| Date: | Sun, 15 May 2016 15:30:09 -0700 |
| Cc: | |
| Delivered-to: | pcp@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1463351409; bh=Q3z7zqCf9gMCyK/PV3u7YQfT6MoP8Q7zvQpGcor6IKs=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=svmtJ/Vk5InKiC28qmgd2ZAAV4vQcmA5+/GFnab2NZfim/ghfBp8hTf5aVLcP53F7 1vcrgGppJ3GMQJA8IcH16cgiwB1pJLBjio7xdVRMEJU32EdF5rG+F2eTL96GiVPKAR e/9G/CndkOCf6aNdbYLm7FGaZP0x5TzymIbCyFkE= |
| In-reply-to: | <performancecopilot/pcp/issues/93@xxxxxxxxxx> |
| List-archive: | https://github.com/performancecopilot/pcp |
| List-id: | performancecopilot/pcp <pcp.performancecopilot.github.com> |
| List-post: | <mailto:reply+00bd08b69feddb308835d88995e82ade5bc69fd323ec797b92cf000000011350ba7192a169ce093ac9ea@reply.github.com> |
| List-unsubscribe: | <mailto:unsub+00bd08b69feddb308835d88995e82ade5bc69fd323ec797b92cf000000011350ba7192a169ce093ac9ea@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0ItlAz_9ttK8eVNxrb5GIyJVvvnpo1ks5qB55xgaJpZM4IelFK> |
| References: | <performancecopilot/pcp/issues/93@xxxxxxxxxx> |
| Reply-to: | performancecopilot/pcp <reply+00bd08b69feddb308835d88995e82ade5bc69fd323ec797b92cf000000011350ba7192a169ce093ac9ea@xxxxxxxxxxxxxxxx> |
|
The util.c:1796 memory leak seems legit; if names = realloc() succeeds but the [n-1]=malloc() fails, then names[] is unfreed. Similarly, logutil.c:1516, that error could result in pr being unfreed. — |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [performancecopilot/pcp] logportmap.c:413]: (style) Suspicious condition (#93), Ken McDonell |
|---|---|
| Next by Date: | Re: [performancecopilot/pcp] logportmap.c:413]: (style) Suspicious condition (#93), Ken McDonell |
| Previous by Thread: | Re: [performancecopilot/pcp] logportmap.c:413]: (style) Suspicious condition (#93), Ken McDonell |
| Next by Thread: | Re: [performancecopilot/pcp] logportmap.c:413]: (style) Suspicious condition (#93), Ken McDonell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |