Re: [pcp] OpenBSD support, EPROTO question (#71)

[Nathan Scott <notifications@xxxxxxxxxx>]

I'm not really a developer so I'm asking before pull request? How to handle in better way EPROTO? > It seems odd to have ifndef in couple of files?

@jirib defining it in src/include/pcp/config.h.in is the way to go - for example, see the EHOSTDOWN/ENODATA missing-error-code definitions there for Windows.

From scanning the available error codes here:
http://fxr.watson.org/fxr/source/sys/errno.h?v=OPENBSD

and looking at the places EPROTO is used, I'd suggest a better match (than EINTR) would be:
#define ENOPROTOOPT 42 /* Protocol not available */

| (Otherwise with diffs below I could build pcp on OpenBSD. Just build, I have to learn how to use it :) )

Good stuff! You might find the quick reference guide useful for getting a quick, practical introduction:
http://www.pcp.io/docs/guide.html

—
Reply to this email directly or view it on GitHub.