Re: [pcp] Cannot build on FreeBSD 11-CURRENT (#60)

To:	performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx>
Subject:	Re: [pcp] Cannot build on FreeBSD 11-CURRENT (#60)
From:	Ken McDonell <notifications@xxxxxxxxxx>
Date:	Wed, 13 Jan 2016 12:09:07 -0800
Delivered-to:	pcp@xxxxxxxxxxx
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1452715747; bh=KjKNVlvnYGSYLpayeX6mOWjmdnSag9BeO7C1F7XXvG0=; h=From:Reply-To:To:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HogO66kgzsfZ08hlLvtuuwSI20XGRE7mLSXFyLk3taSkZVJ6o96w/x7O84RN+7hLj icm6rZ6/3yzBTxB1AD3SP9EEQiaEul9ouNLhN08K3/k5DME0KIC6vP0W8AHxsHYOfs UoV7DcKCWeOQGc7DcpToR7o5w7/22u7HQ9hWHfjQ=
In-reply-to:	<performancecopilot/pcp/issues/60@xxxxxxxxxx>
List-archive:	https://github.com/performancecopilot/pcp
List-id:	performancecopilot/pcp <pcp.performancecopilot.github.com>
List-post:	<mailto:reply+00bd08b63ed3c6e7bc996dc09c75c389a72f46423feea81192cf0000000112ae70e392a169ce0785e8e4@reply.github.com>
List-unsubscribe:	<mailto:unsub+00bd08b63ed3c6e7bc996dc09c75c389a72f46423feea81192cf0000000112ae70e392a169ce0785e8e4@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0IttvvY9cdbQuovxSc4YQPOZj1TFSoks5pZqZjgaJpZM4HDSNP>
References:	<performancecopilot/pcp/issues/60@xxxxxxxxxx>
Reply-to:	performancecopilot/pcp <reply+00bd08b63ed3c6e7bc996dc09c75c389a72f46423feea81192cf0000000112ae70e392a169ce0785e8e4@xxxxxxxxxxxxxxxx>

You're correct on a couple of fronts.
1. using /dev/kmem was a throwback to Unix versions 20+ years ago ... rather than the plan of choice it is the fallback plan wired into my brain when ignorance hides a more modern API ... and I'm clearly not a FreeBSD guru.
2. FreeBSD 11 is missing from my QA matrix.

Let me fix 2. then apply your patch (which looks OK from a quick scan), test and then I'll commit.

Thanks for taking the time and effort.

—
Reply to this email directly or view it on GitHub.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [pcp] Cannot build on FreeBSD 11-CURRENT (#60), Ken McDonell <= Re: [pcp] Cannot build on FreeBSD 11-CURRENT (#60), Ken McDonell Re: [pcp] Cannot build on FreeBSD 11-CURRENT (#60), Ken McDonell

Previous by Date:	[Bug 948] PMDAs should not be shipped without some QA coverage, bugzilla-daemon
Next by Date:	pcp updates: misc, Ken McDonell
Previous by Thread:	[Bug 948] PMDAs should not be shipped without some QA coverage, bugzilla-daemon
Next by Thread:	Re: [pcp] Cannot build on FreeBSD 11-CURRENT (#60), Ken McDonell
Indexes:	[Date] [Thread] [Top] [All Lists]