Re: [pcp] pmatop crashes when it encounters pid >= 1000000 (#58)

[Lukas Berk <notifications@xxxxxxxxxx>]

Hi,

Thanks for reporting this issue! I'm working to reproduce this now, however, I'm weary that the large PID might be a red herring here. From the output, it appears that the 'name' var is empty, which in the context of the update_task function:

strsep(&name, " "); /* remove process identifier prefix */
strncpy(task->gen.cmdline, name, CMDLEN);

Means, the return of strsep would be NULL, and name would be empty (running through this with gdb and

set name = ""

lead to a similar SEGV. Regardless of whether or not the large PID is causing this issue (which I'm still looking into), it appears we need to be more careful with our assumptions of the name being passed to update_task.

—
Reply to this email directly or view it on GitHub.