[pcp] Memory leak detected by Valgrind (#56)

[e03213ac <notifications@xxxxxxxxxx>]

This Valgrind error was generated on 3108 but it also applies to the latest master branch:

==109671== 5 bytes in 1 blocks are definitely lost in loss record 1 of 6
==109671==    at 0x4C27A2E: malloc (vg_replace_mallocc:270)
==109671==    by 0x505ACB3: DecodeNameReq (p_pmnsc:519)
==109671==    by 0x4E37247: __pmdaMainPDU (mainloopc:232)
==109671==    by 0x4E378C7: pmdaMain (mainloopc:428)
==109671==    by 0x402A34: main (fbit_mainc:271)

The problem is in src/libpcp_pmda/src/mainloopc, line 232:

if ((sts = __pmDecodeChildReq(pb, &name, &subtype)) >= 0) {

The name string is not freed

Suggested patch:

diff --git a/src/libpcp_pmda/src/mainloopc b/src/libpcp_pmda/src/mainloopc
index 5dff1a9b900b72 100644
--- a/src/libpcp_pmda/src/mainloopc
+++ b/src/libpcp_pmda/src/mainloopc
@@ -243,6 +243,7 @@ __pmdaMainPDU(pmdaInterface *dispatch)
                /* Not INTERFACE_4 */
                sts = PM_ERR_NAME;
            }
+           free(name);
        }
        if (sts < 0)
            __pmSendError(pmda->e_outfd, FROM_ANON, sts);

—
Reply to this email directly or view it on GitHub.