Re: [pcp] Memory leak detected by Valgrind (#56)

To:	performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx>
Subject:	Re: [pcp] Memory leak detected by Valgrind (#56)
From:	Ken McDonell <notifications@xxxxxxxxxx>
Date:	Sun, 13 Dec 2015 02:01:30 -0800
Authentication-results:	i-otc1esa.cbr1.mail-filtering.com.au; spf=Pass smtp.mailfrom=noreply@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Delivered-to:	pcp@xxxxxxxxxxx
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1450000890; bh=pqRoNyhWK8JX/eEQLOcvq70vvY9ZVcFzpvNrW3kKQ2o=; h=From:Reply-To:To:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Wq2+yDN8LqirL5mPOxiDYwpD/K59PbmXaJgEvg3kQamZjC1gq4Ma7p0JOXVZ9ts5i KyAkCvMGvSJV5rPek3YRECQmkm/25XHjOdXmrvdsAC6kY52cPm3dzf/BmV1FtDSflh r5y6d/Ls8JzWxNPp6m4td20v8xt+CaqYInPGVvpQ=
In-reply-to:	<performancecopilot/pcp/issues/56@xxxxxxxxxx>
Ironport-phdr:	9a23:Ghv6ixOty+eMzxlEwCYl6mtUPXoX/o7sNwtQ0KIMzox0LP/9rarrMEGX3/hxlliBBdydsKIazbCN+PiwEUU7or+/81k6OKRWUBEEjchE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i760zceF13FOBZvIaytQ8iJ35rxjbv5o82bSj4LrQT+SIs6FA+xowTVu5teqqpZAYF19CH0pGBVcf9d32JiKAHbtR/94sCt4MwrqHwI6Lpyv/NGSrjwKqExTLhEC2Y7NXso7o6z7RPPFVuFuCQRXm8cykZGDlKa4h+gUM/76Hem77J20iSWZ52oHOpkA276vv9nQ0a50iwJb2ZhqDmP0pUp1vIG+Emvrk0lyteKMYqYbKUiJPKFc9kyX2dZWtcXWC1dAp62KYAICrk8O/1Fpdz9u0cWtkn5QgatGOPywHlDgXqx26om0uogGgja3QsmBJUTtm/Jps7+LqYYXKec6PHp0TrpMOFJgD79xo6QdRoDgOqnBZd0aJH/5kozMADe002olYi7MDq3ztYo70eJv8U6Bt6o3nYqsQ92uD2mwMwhgY7Rh4YS1hfc/j0xlJ4+PfW+T1R2edq1VpRRqyGHPc19RcZ0EFtloCIr9rpToZOhci8QzZ0hzBPUbOSGd4+UpQroTK7FOzpggGMmIOq1i07i+xb/x+H2XJHo3lsQ8SRLyNeUvCpRi0WL4cKKRqEtoBb7iWzVj1GL5uodcBo/m/KDc8Z5muZpz8BD7ByYECanwkyv0v6dex17prL5s+rtSq/rvpuNcYB1lgHjOOIlncnpUsoiNQ1bfGWdscG3+Lrl8En9COFMieE3nKjSuYzbIsIAjqG4Hw9I2MAo7BPpXGTu68gRgXRSdAENQxmAlYW8Y1w=
List-archive:	https://github.com/performancecopilot/pcp
List-id:	performancecopilot/pcp <pcp.performancecopilot.github.com>
List-post:	<mailto:reply+00bd08b67edbb04fe27ff2f0b24410cbed28692822090dc192cf00000001128503fa92a169ce074290fb@reply.github.com>
List-unsubscribe:	<mailto:unsub+00bd08b67edbb04fe27ff2f0b24410cbed28692822090dc192cf00000001128503fa92a169ce074290fb@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0ItgB7zw1ahFn0obJIsC0Mlq3FGktOks5pPTl6gaJpZM4Gz8G2>
References:	<performancecopilot/pcp/issues/56@xxxxxxxxxx>
Reply-to:	performancecopilot/pcp <reply+00bd08b67edbb04fe27ff2f0b24410cbed28692822090dc192cf00000001128503fa92a169ce074290fb@xxxxxxxxxxxxxxxx>

Yep, definitely a bug and the patch looks correct ... I'll push it forward [e03213ac of you want to send me your real name/email addr to kenj@xxxxxxxxxxx I'll ensure the fix is attributed correctly]

Of more interest (at least to me) is how we missed this in the PCP QA suite ... we make extensive use of valgrind to help find exactly this sort of issue, so we have a coverage problem here.

Can you share the recipe used to reproduce this?

—
Reply to this email directly or view it on GitHub.

<Prev in Thread]	Current Thread	[Next in Thread>
[pcp] Memory leak detected by Valgrind (#56), e03213ac Re: [pcp] Memory leak detected by Valgrind (#56), Ken McDonell <= Re: [pcp] Memory leak detected by Valgrind (#56), e03213ac Re: [pcp] Memory leak detected by Valgrind (#56), Ken McDonell Re: [pcp] Memory leak detected by Valgrind (#56), Ken McDonell Re: [pcp] Memory leak detected by Valgrind (#56), Ken McDonell Re: [pcp] Memory leak detected by Valgrind (#56), Ken McDonell

Previous by Date:	pcp updates: qa incl Frank's changes for 652, Ken McDonell
Next by Date:	Re: [pcp] pmda-systemd qa tweak, Marko Myllynen
Previous by Thread:	[pcp] Memory leak detected by Valgrind (#56), e03213ac
Next by Thread:	Re: [pcp] Memory leak detected by Valgrind (#56), e03213ac
Indexes:	[Date] [Thread] [Top] [All Lists]