pcp
[Top] [All Lists]

Re: [pcp] _pm_ispartition() heulistic miss some block devices (#45)

To: performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx>
Subject: Re: [pcp] _pm_ispartition() heulistic miss some block devices (#45)
From: Nathan Scott <notifications@xxxxxxxxxx>
Date: Wed, 26 Aug 2015 21:49:10 -0700
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha1; c=relaxed; d=github.com; h=from:reply-to:to:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=136qemeDu84rjISBdbLsIpl7GZI=; b=bRpRD1800RRenr8j l89QRpGxUG5MGLsjSOPTphn9nC/1uHF9FQgqqm5r58n9sf8CTBI9p2/63H3jEx6E oLyl4XxBNB7InRm1gCbMlUF0uWoUW+jQvK9qFTwf3u5Morx40qvWaobEh/2HNVkO XrzGfHt3r1WLoJXGXH+Q8bhRWNE=
In-reply-to: <performancecopilot/pcp/issues/45@xxxxxxxxxx>
List-archive: https://github.com/performancecopilot/pcp
List-id: performancecopilot/pcp <pcp.performancecopilot.github.com>
List-post: <mailto:reply+00bd08b60dab270ba956ddced87e0f187b9185275b085c5d92cf0000000111f658c692a169ce062700ab@reply.github.com>
List-unsubscribe: <mailto:unsub+00bd08b60dab270ba956ddced87e0f187b9185275b085c5d92cf0000000111f658c692a169ce062700ab@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0ItkUlJGTM6Hj4EidLmaYKfrKwnsb3ks5oro5GgaJpZM4FyZgl>
References: <performancecopilot/pcp/issues/45@xxxxxxxxxx>
Reply-to: performancecopilot/pcp <reply+00bd08b60dab270ba956ddced87e0f187b9185275b085c5d92cf0000000111f658c692a169ce062700ab@xxxxxxxxxxxxxxxx>

I thought that new devices' or some special drivers' naming rules are uncontrollable.
And proper block device detection method can be help for minor devices and users.

Yes, this could certainly be done and would be an improvement I think. We would need to ensure the current code remains though, as it will need to run on older kernels lacking sysfs support. Would you be interested in sending through a patch?


Reply to this email directly or view it on GitHub.

<Prev in Thread] Current Thread [Next in Thread>