pcp
[Top] [All Lists]

Re: [performancecopilot/pcp] pmcd wants to bind on ipv6 event if it is d

To: performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx>
Subject: Re: [performancecopilot/pcp] pmcd wants to bind on ipv6 event if it is disabled (#102)
From: dbrolley <notifications@xxxxxxxxxx>
Date: Thu, 04 Aug 2016 09:31:29 -0700
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1470328289; bh=6bUOJ8ocXhB34ocALt/GrdHlBnKqmvs+nRGHyus4UMw=; h=From:Reply-To:To:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=O6iclWippxPZsRkLjkfhb8VRnzPKSbaHB/EpYR5BYXqthAmedXnPNmKhPu9Ru7Urc NLLcQVbDuGJmxuwsAPdxW53O80qUQ/tJgJ1gA86kWf4PN3IrU72scA8KrJvUknrs6/ 7g/a7nKvwxwUowNxeMF4h6koalHLureQWO2AuP3s=
In-reply-to: <performancecopilot/pcp/issues/102@xxxxxxxxxx>
List-archive: https://github.com/performancecopilot/pcp
List-id: performancecopilot/pcp <pcp.performancecopilot.github.com>
List-post: <mailto:reply+00bd08b69f505a7f49886c9b9202de658b5d9dfb4cc9273d92cf0000000113bb2fe192a169ce0a10b176@reply.github.com>
List-unsubscribe: <mailto:unsub+00bd08b69f505a7f49886c9b9202de658b5d9dfb4cc9273d92cf0000000113bb2fe192a169ce0a10b176@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0ItmIvrMEjJ6Y408saMsKMo4iP-hRXks5qchPhgaJpZM4JahoX>
References: <performancecopilot/pcp/issues/102@xxxxxxxxxx>
Reply-to: performancecopilot/pcp <reply+00bd08b69f505a7f49886c9b9202de658b5d9dfb4cc9273d92cf0000000113bb2fe192a169ce0a10b176@xxxxxxxxxxxxxxxx>
On 08/03/2016 06:07 PM, Nathan Scott wrote:
>
> __pmServerSetFeature(PM_SERVER_FEATURE_LOCAL)
>
> In this case, the above call is performed (pmcd main.c) solely to
> ensure the pmcd.feature.local metric can export that setting.
>
> but I can't see where
> __pmServerHasFeature(PM_SERVER_FEATURE_LOCAL) is ever called. As >
> far as I can tell, this feature has no effect on pmcd.
>
> All of the work is done in pmcd main.c so it turns out there's no need
> to test it using that interface (unlike most of the other feature flags).
>
>
OK, so the main issue is that the implementation of ipv6_enabled() is
inadequate for detecting that ipv6 is disabled on this platform. I have
no idea how to fix this.

The behaviour of PMCD_LOCAL is a secondary issue. It is correctly adding
the loopback (INADDR_LOOPBACK) interface and disabling the use of
INADDR_ANY, but it does not prevent the use of the -i option to add
other interfaces. The man page suggests that -i should perhaps be
disabled in this mode.

Dave


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<Prev in Thread] Current Thread [Next in Thread>