pcp
[Top] [All Lists]

[performancecopilot/parfait] Fix non-weak reference regression introduce

To: performancecopilot/parfait <parfait@xxxxxxxxxxxxxxxxxx>
Subject: [performancecopilot/parfait] Fix non-weak reference regression introduced with Guava upgrade (#34)
From: Ryan Doyle <notifications@xxxxxxxxxx>
Date: Thu, 15 Sep 2016 19:12:33 -0700
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha1; c=relaxed; d=github.com; h=from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=NyU97M5dxrQ8sQ634BxljbD3cco=; b=oKF+NBGz271NmybV 1zmRO2juVwMlhUzzTvgYxsLIK1Yd6fSoDLgIy5hkWKRlm1yZhqTQN0Kbo8E1jO5R 1jiF6kC6WlCiPLYeZ6bIHScWL/MkRn3MgNQUdvdPptVTOaFxwQSAYmmVO5HMI0Mp Z22LjZV9bB9d4dHZaozGZBFrUPI=
List-archive: https://github.com/performancecopilot/parfait
List-id: performancecopilot/parfait <parfait.performancecopilot.github.com>
List-post: <mailto:reply+00bd08b66c5631922ddf9e257b5cb452c0a08741b5353d1892cf0000000113f3171192a169ce0a91de7a@reply.github.com>
List-unsubscribe: <mailto:unsub+00bd08b66c5631922ddf9e257b5cb452c0a08741b5353d1892cf0000000113f3171192a169ce0a91de7a@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0ItoVBj4FPU8h7x4BhvZhTOUadFHDgks5qqfsRgaJpZM4J-iS4>
Reply-to: performancecopilot/parfait <reply+00bd08b66c5631922ddf9e257b5cb452c0a08741b5353d1892cf0000000113f3171192a169ce0a91de7a@xxxxxxxxxxxxxxxx>

In 0c858c8, this map was migrated to
LoadingCache. The weakKeys() builder method accidentally got dropped and
the defaults are to hold strong references. This commit re-introduces the
weakKeys() builder method for the LoadingCache.


You can view, comment on, or merge this pull request online at:

  https://github.com/performancecopilot/parfait/pull/34

Commit Summary

  • Fix non-weak reference regression introduced with Guava upgrade

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<Prev in Thread] Current Thread [Next in Thread>