pcp
[Top] [All Lists]

[performancecopilot/parfait] Fix non-weak reference regression introduce

To: performancecopilot/parfait <parfait@xxxxxxxxxxxxxxxxxx>
Subject: [performancecopilot/parfait] Fix non-weak reference regression introduced with Guava upgrade (#33)
From: Ryan Doyle <notifications@xxxxxxxxxx>
Date: Thu, 15 Sep 2016 19:07:37 -0700
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha1; c=relaxed; d=github.com; h=from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=3r+4byl5QKihE0/ltN9KR0KWvhk=; b=kB5Zwzl3P0micIYe 8bAfwpY0d2PgQpEOqWsUHMX7gGhbi473ogDEFasKBLFIDlLISNmwC+aBEVUZbHeu GqBLmzlbveuk9/OrQfdat2fhhHe/g7bo4XzH+6hKkBGvER7uADKp+7EIt2bXfoEn gRjWxrlAzzH0mFRd3iRaeen7bPo=
List-archive: https://github.com/performancecopilot/parfait
List-id: performancecopilot/parfait <parfait.performancecopilot.github.com>
List-post: <mailto:reply+00bd08b6ffda225b20c21fa6fa9d9660d4a3e3a07a81072f92cf0000000113f315e992a169ce0a91dcc5@reply.github.com>
List-unsubscribe: <mailto:unsub+00bd08b6ffda225b20c21fa6fa9d9660d4a3e3a07a81072f92cf0000000113f315e992a169ce0a91dcc5@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0Itg2GhsgJapY77KdYdWaFCodc7qDkks5qqfnpgaJpZM4J-iKy>
Reply-to: performancecopilot/parfait <reply+00bd08b6ffda225b20c21fa6fa9d9660d4a3e3a07a81072f92cf0000000113f315e992a169ce0a91dcc5@xxxxxxxxxxxxxxxx>

In 0c858c8, this map was migrated to
LoadingCache. The weakKeys() builder method accidentally got dropped and
the defaults are to hold strong references. This commit re-introduces the
weakKeys() builder method for the LoadingCache.


You can view, comment on, or merge this pull request online at:

  https://github.com/performancecopilot/parfait/pull/33

Commit Summary

  • Fix non-weak reference regression introduced with Guava upgrade

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<Prev in Thread] Current Thread [Next in Thread>