pcp
[Top] [All Lists]

libvirt pmda: add support for new perf metrics

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: libvirt pmda: add support for new perf metrics
From: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Tue, 4 Oct 2016 22:40:28 +0300
Delivered-to: pcp@xxxxxxxxxxx
Organization: Red Hat
Reply-to: Marko Myllynen <myllynen@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
Hi,

libvirt 2.3 added a couple of new perf metrics:

https://libvirt.org/git/?p=libvirt.git;a=commit;h=bae660869de0612bee2a740083fb494c27e3f80c

After some consultation with FChE, the types below are believed to
be correct, considering also:

https://bugzilla.redhat.com/show_bug.cgi?id=1381714

It would be of course nice if someone with access to a system
supporting all these events / metrics would be able to confirm.

---
 src/pmdas/libvirt/pmdalibvirt.python | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/pmdas/libvirt/pmdalibvirt.python 
b/src/pmdas/libvirt/pmdalibvirt.python
index e88e11a..d34c95c 100755
--- a/src/pmdas/libvirt/pmdalibvirt.python
+++ b/src/pmdas/libvirt/pmdalibvirt.python
@@ -247,6 +247,10 @@ class LibvirtPMDA(PMDA):
             [ 'domstats.perf.cmt',               None,                       
PM_TYPE_U64,    PM_SEM_INSTANT,  units_bytes, 'VM perf stats, cmt'              
  ],
             [ 'domstats.perf.mbmt',              None,                       
PM_TYPE_U64,    PM_SEM_INSTANT,  units_bpers, 'VM perf stats, mbmt'             
  ],
             [ 'domstats.perf.mbml',              None,                       
PM_TYPE_U64,    PM_SEM_INSTANT,  units_bpers, 'VM perf stats, mbml'             
  ],
+            [ 'domstats.perf.cpu_cycles',        None,                       
PM_TYPE_U64,    PM_SEM_COUNTER,  units_count, 'VM perf stats, CPU cycles/instr' 
  ],
+            [ 'domstats.perf.instructions',      None,                       
PM_TYPE_U64,    PM_SEM_COUNTER,  units_count, 'VM perf stats, instructions 
count' ],
+            [ 'domstats.perf.cache_references',  None,                       
PM_TYPE_U64,    PM_SEM_COUNTER,  units_count, 'VM perf stats, cache references' 
  ],
+            [ 'domstats.perf.cache_misses',      None,                       
PM_TYPE_U64,    PM_SEM_COUNTER,  units_count, 'VM perf stats, cache misses'     
  ],
         ]
 
         for item in range(len(self.hv_metrics)):

Thanks,

-- 
Marko Myllynen

<Prev in Thread] Current Thread [Next in Thread>
  • libvirt pmda: add support for new perf metrics, Marko Myllynen <=