Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (7):
src/pmlogrewrite/pmlogrewrite.c: fix small error in temporal index
src/libpcp/src/auxconnect.c: fix diagnostic messages
Revert "src/pmlogrewrite/pmlogrewrite.c: fix small error in temporal
index"
src/pmcd/pmdaproc.sh: change default $signal_delay
src/libpcp/src/pmns.c: change logic in __pmHasPMNSFileChanged()
qa/827: tweak to handle changes in temporal index
src/libpcp/src/pmns.c: correct logic in __pmHasPMNSFileChanged()
qa/827 | 9 +++-
qa/827.out | 13 +++++-
qa/admin/pcp-daily | 2
src/libpcp/src/auxconnect.c | 8 +--
src/libpcp/src/check-statics | 1
src/libpcp/src/pmns.c | 85 +++++++++++++++++++++-------------------
src/pmcd/pmdaproc.sh | 2
src/pmlogrewrite/pmlogrewrite.c | 8 +--
8 files changed, 76 insertions(+), 52 deletions(-)
Details ...
commit ee24830c9834ac02702faf13dd4945ea284114f8
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat Oct 29 06:44:56 2016 +1100
src/libpcp/src/pmns.c: correct logic in __pmHasPMNSFileChanged()
One of the predicates was rewritten incorrectly in the last change,
also rework the diagnostics so the result of __pmHasPMNSFileChanged()
is also reported under the control of DBG_TRACE_PMNS.
commit ad8f1c13e4c93c9ae5e9af1ba8c7292d24533208
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Oct 28 09:47:17 2016 +1100
qa/827: tweak to handle changes in temporal index
After pmlogrewrite, these are now expected.
commit 8b39516e1ec4cbf9bf3a1423094141d0ce24350e
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Oct 28 08:56:01 2016 +1100
src/libpcp/src/pmns.c: change logic in __pmHasPMNSFileChanged()
Changes elsewhere have meant that pmcd reconfiguration step are
now significantly quicker (this is good), but this has exposed a latent
design error in __pmHasPMNSFileChanged().
The check for "has the pmns changed" is based on stat()ing the root
PMNS file and checking the mtime ... unfortunately this has only second
resolution on some systems, which was OK when PMDA Install/Remove was
slow ... but not now. Improved the logic to check the file size and
the mtime.
Also needed another static inside the lock guard, so update check-statics
accordingly.
commit 66d805b8ed9b845559aeb39a2a12a3dc644b4b89
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Oct 28 08:53:41 2016 +1100
src/pmcd/pmdaproc.sh: change default $signal_delay
I've found 0.1sec to be unreliable on some QA systems and setting
this to 1sec seems to improve the situation dramatically.
Given the vaguaries of signal delivery, this is not altogether
surprising.
commit 540a5b084b640ff1d57f1808663838355665e865
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Oct 25 08:47:23 2016 +1100
Revert "src/pmlogrewrite/pmlogrewrite.c: fix small error in temporal index"
This reverts commit d35d7efe161fdfe1d9198a02645d44cfa2f49631.
commit 800d6b80562333aa343e0eeb22fbf3d6a1a236b2
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Oct 25 08:39:14 2016 +1100
src/libpcp/src/auxconnect.c: fix diagnostic messages
Message contained wrong routine name.
commit d35d7efe161fdfe1d9198a02645d44cfa2f49631
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Oct 25 08:37:37 2016 +1100
src/pmlogrewrite/pmlogrewrite.c: fix small error in temporal index
Metadata offset arithmetic was not quite right ... Nathan spotted
this in qa/827.
|