pcp
[Top] [All Lists]

Re: [PATCH 01/12] Fix Windows PMDA build

To: Nathan Scott <nscott@xxxxxxxxxx>
Subject: Re: [PATCH 01/12] Fix Windows PMDA build
From: Michael Newton <kimbrr@xxxxxxxxxxxxxxxxx>
Date: Thu, 7 Dec 2006 16:34:04 +1100
Cc: Mark Goodwin <markgw@xxxxxxx>, pcp@xxxxxxxxxxx
In-reply-to: <1165468793.30459.9.camel@edge>
References: <1163999314.4695.231.camel@edge> <1164321131.4695.368.camel@edge> <Pine.SGI.4.58.0612061551470.53803701@snort.melbourne.sgi.com> <1165381359.1281.113.camel@edge> <1165383346.1281.123.camel@edge> <Pine.SGI.4.58.0612071454030.55709270@snort.melbourne.sgi.com> <1165468793.30459.9.camel@edge>
Sender: pcp-bounce@xxxxxxxxxxx
On Thu, 7 Dec 2006, Nathan Scott wrote:
> On Thu, 2006-12-07 at 15:58 +1100, Michael Newton wrote:
> > On Wed, 6 Dec 2006, Nathan Scott wrote:
> >  the patch was to delete ".uu" from
> > pmda/windows/GNUmakefile right?
>
> Right.
>
> > When i do that, from a clean build i get
> >
> > gmake[5]: *** No rule to make target `show-all-ctrs.save', needed by
> > `src-pcp'.
>
> Oh.  Does the ptools tree not have any *.save files checked in at all?
> I thought Max had checked those in... guess not?  If not, we can just
> have a default .save Makefile rule which touches the file.  Lemme know,
> I'll send a followup patch if you've not got any .save files in ptools.

i dont see anything..

kimbrr@chook:/build/kimbrr/pcp> grep 'windows.*save' census
src/pmdas/windows/shim.save%kimbrr%1.1|2004.07.12.02.43.23{t}
src/pmdas/windows/shim.save.uu%kimbrr%1.1|2006.06.30.06.57.22{t}
src/pmdas/windows/show-all-ctrs.save.uu%kimbrr%1.1|2006.06.30.06.48.59{t}
kimbrr@chook:/build/kimbrr/pcp>
 :
kimbrr@chook:/build/kimbrr/mangrove/mgmt/pcp> p_rlog
src/pmdas/windows/shim.save*
RCS log for mgmt/pcp/src/pmdas/windows/shim.save

RCS file:
/plroot/eoe/pcp-1.0-melb/.RCS/PL/src/pmdas/windows/RCS/shim.save,v
Working file: shim.save
head: 1.1
branch:
locks: strict
access list:
symbolic names:
keyword substitution: kv
total revisions: 1;     selected revisions: 1
description:
----------------------------
revision 1.1
date: 2004/07/12 02:43:23;  author: kenmcd;  state: Exp;
modid: pcp-1.0:eoe:17970a
pv:916303 restructure to support pmda + shim arcitecture, needed for SFU
=============================================================================
RCS log for mgmt/pcp/src/pmdas/windows/shim.save.uu

RCS file:
/plroot/eoe/pcp-1.0-melb/.RCS/PL/src/pmdas/windows/RCS/shim.save.uu,v
Working file: shim.save.uu
head: 1.1
branch:
locks: strict
access list:
symbolic names:
keyword substitution: kv
total revisions: 1;     selected revisions: 1
description:
----------------------------
revision 1.1
date: 2006/06/30 06:57:22;  author: makc;  state: Exp;
modid: pcp-1.0:eoe:26392a
pv:954343 - changes from Ken McDonell(kenj@xxxxxxxxxxxxxxxx)
=============================================================================
kimbrr@chook:/build/kimbrr/mangrove/mgmt/pcp> p_rlog
src/pmdas/windows/show-all-ctrs.save.uu
RCS log for mgmt/pcp/src/pmdas/windows/show-all-ctrs.save.uu

RCS file:
/plroot/eoe/pcp-1.0-melb/.RCS/PL/src/pmdas/windows/RCS/show-all-ctrs.save.uu,v
Working file: show-all-ctrs.save.uu
head: 1.1
branch:
locks: strict
access list:
symbolic names:
keyword substitution: kv
total revisions: 1;     selected revisions: 1
description:
----------------------------
revision 1.1
date: 2006/06/30 06:48:59;  author: makc;  state: Exp;
modid: pcp-1.0:eoe:26391a
pv:954343 - add changes made by Ken McDonell (kenj@xxxxxxxxxxxxxxxx)
=============================================================================
kimbrr@chook:/build/kimbrr/mangrove/mgmt/pcp>



> > > I did notice one unrelated issue when doing a test build just now,
> > this is an increment to the other stomp patch, right? just want to sure as
> > i think i'll put this stuff ona separate PV, as its a larger homogenous
> > change
>
> Yep, and that sounds fine.
>
> thanks!
>
> --
> Nathan
>
>

<Prev in Thread] Current Thread [Next in Thread>