pcp
[Top] [All Lists]

Re: [pcp] pcp updates: embed shell fragments in pmlogger control file

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: [pcp] pcp updates: embed shell fragments in pmlogger control file
From: Martins Innus <minnus@xxxxxxxxxxx>
Date: Mon, 19 Oct 2015 17:55:51 -0400
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <56255B5A.9000305@xxxxxxxxxxxxxxxx>
References: <56255B5A.9000305@xxxxxxxxxxxxxxxx>
Ken,

   Thanks very much for this! Will test tommorrow.

Martins

> On Oct 19, 2015, at 5:06 PM, Ken McDonell <kenj@xxxxxxxxxxxxxxxx> wrote:
> 
> All done for pmlogger.  pmie will follow later.
> 
> Changes committed to git://git.pcp.io/kenj/pcp master
> 
> Ken McDonell (4):
>      qa/089: improve test stability
>      qa/184&292: ensure primary pmlogger is restarted
>      qa/993&1094: (new) exercise shell escape in pmlogger control file
>      pmlogger_*: add shell escape for "directory" field of control file
> 
> man/man1/pmlogger_check.1      |   60 ++++++++++++++---
> qa/089                         |   10 ++
> qa/1094                        |   68 +++++++++++++++++++
> qa/1094.out                    |   65 +++++++++++++++++++
> qa/184                         |   13 +++
> qa/292                         |   12 ++-
> qa/793                         |  140 
> +++++++++++++++++++++++++++++++++++++++++
> qa/793.out                     |   91 ++++++++++++++++++++++++++
> qa/group                       |    2 
> src/pmlogger/GNUmakefile       |    1 
> src/pmlogger/pmlogger_check.sh |    7 ++
> src/pmlogger/pmlogger_daily.sh |    7 ++
> src/pmlogger/utilproc.sh       |   82 ++++++++++++++++++++++++
> 13 files changed, 539 insertions(+), 19 deletions(-)
> 
> Details ...
> 
> commit 2c87ff9a6ad551af149358c28e13cd5058c48043
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Tue Oct 20 08:01:50 2015 +1100
> 
>    pmlogger_*: add shell escape for "directory" field of control file
> 
>    The control file used by pmlogger_check and pmlogger_daily now
>    supports embedded shell escapes for the "directory" field.
> 
>    From the man page ...
>    The allowed constructs are:
>        Â Any text (including white space) enclosed with $( and ).
>        Â Any text (including white space) enclosed with ` and ` (back quotes).
>        Â Any text (including white space) enclosed with " and " (double 
> quotes).
>        Â Any word containing a $ (assumed to introduce an environment
>          variable name).
> 
> commit dfb87bbd9aec31ca4460f6f92b6f1fe7c5fe3bc7
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Tue Oct 20 07:59:19 2015 +1100
> 
>    qa/993&1094: (new) exercise shell escape in pmlogger control file
> 
>    Recent pmlogger_* changes to allow the directory field of the
>    control file to contain embedded sh(1) constructs.
> 
> commit 8b3ddc05c69333fb50d3ab0db1458ca89495bf3f
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Tue Oct 20 07:56:48 2015 +1100
> 
>    qa/184&292: ensure primary pmlogger is restarted
> 
>    These tests kill off the primary pmlogger and did not restart
>    it.  When running _all_ of QA the issue is masked because some
>    test later on restarts the primary pmlogger, but running
>    -g logutil exposed the problem.
> 
> commit 0130f0dfcd14ab54059ece129dba38032856cce0
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Tue Oct 20 06:52:36 2015 +1100
> 
>    qa/089: improve test stability
> 
>    After recent "log early" changes to pmlogger, the archive used in
>    this test (qa/src/bar) that is created on the fly as needed may
>    contain some variablility in the timestamp intervals at the
>    beginning of the archive.  Skip this first few samples to get
>    into the stable part of the archive.
> 
> _______________________________________________
> pcp mailing list
> pcp@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/pcp

<Prev in Thread] Current Thread [Next in Thread>