pcp
[Top] [All Lists]

Re: PCP web client on different domain

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: PCP web client on different domain
From: Martin Spier <mspier@xxxxxxxxxxx>
Date: Tue, 9 Sep 2014 18:31:29 -0700
Cc: "Frank Ch. Eigler" <fche@xxxxxxxxxx>, Amer Ather <aather@xxxxxxxxxxx>, Coburn Watson <cwatson@xxxxxxxxxxx>, pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=GWb//q/G904cxiFWLEJysqLEk9WQmlb8htmoRyj9K/w=; b=noJ/PJMw3dpJrR8iM8187fe+uPRnydU2tKl1CHTp4Mddtcgt31yBBqdV+LJTF3v/sx /iy4CONbCNIrmpHm+qoAfNM+5Mj5cFbCkGqsPWTIAqv8bTgf+RsGsX5BsTJ+/hGGSMk9 nFANM9mR7Y21+Rpt+t9Q+nsTi/UTL0DBIkStI=
In-reply-to: <1678088280.23964559.1402473510747.JavaMail.zimbra@xxxxxxxxxx>
References: <CAM1aq-F=7BgLJFTNSo4nmzf7Lcjv-7mLDaStfxRaZrD-7WuF8Q@xxxxxxxxxxxxxx> <1717887824.20744079.1401960303984.JavaMail.zimbra@xxxxxxxxxx> <20140605115447.GC11474@xxxxxxxxxx> <1295610433.21793898.1402006255252.JavaMail.zimbra@xxxxxxxxxx> <y0m61ka11e9.fsf@xxxxxxxx> <CAEp4+dW78zqcxQ_9Wr=kPGSfNbqEAfMP+2f32DeqL13BsbQVSg@xxxxxxxxxxxxxx> <878364148.23139544.1402347444401.JavaMail.zimbra@xxxxxxxxxx> <y0mzjhkzh28.fsf@xxxxxxxx> <1678088280.23964559.1402473510747.JavaMail.zimbra@xxxxxxxxxx>
Noticed today that the ACAO header is only being returned on success responses (2xx). I have a few error cases where context might have expired or some other problem, and an error response (4xx, 5xx) response is expected. The error message is in the body, but I can't access it because of the missing ACAO header. Message is useful in order to handle the error (get new context) or do something else (abort).

On Wed, Jun 11, 2014 at 12:58 AM, Nathan Scott <nathans@xxxxxxxxxx> wrote:


----- Original Message -----
> > [...]
> > Sounds good - could you send through a tested variant of that approach,
> > Frank, or shall I code it up today?
>
> Please see the pcpfans.git fche/pmwebd-acao branch for two related &
> tested commits.

Looks OK. I've added regression test qa/780 and made some small error
handling consistency improvements (please review? thanks) - all merged
in now.

Martin, if you could try out the git://git.performancecopilot.org/pcp
dev branch pmwebd with your code, that'd be great - thanks.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>