pcp
[Top] [All Lists]

Shouldn't pmrep use the default config file?

To: pcp@xxxxxxxxxxx
Subject: Shouldn't pmrep use the default config file?
From: Jamie Bainbridge <jamie.bainbridge@xxxxxxxxx>
Date: Fri, 17 Jun 2016 10:35:28 +1000
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=7O3comeT5RRZDotGaH5wGsd7TzWXToyNKpDJ48hvvRI=; b=z3HQo+zOgyPMttuv67Yagh4KmMvADusyoTqvdG20obtgKXOshH2VlQZ6kQBnJpQqrC OSazXijGj1dGVEcEUp0L53i3RiaA1v12/t0o70DZ8PfQGTSK+wEuqoAtcjVhzxsb1wS4 353DOy9nO6EQBHBcpIZJRViG/C1TI1AO7HWPxxiqORmzQ1sPITaWcJgwGf+gvl9Cj6xy zbtGlHl2ILHnAHKByJJkQImoJCVuEly0UKFDcNXRLAjO7LjrWo2dtu4VliMvEuDzXlhc 8KdxoGcFtUC+f1u96op+RCZuAPxicdfRasTqJq6I4dUgDrZPgLvxARI+AbVdX7DvmO/B PVFQ==
The pmrep manpage invites you to use a metric spec, but this does not
work by default:

# pmrep -p -b MB vfs.inodes.count :vmstat
Metric set definition ':vmstat' not found.

One has to specify the supplied config file for the command to work:

# pmrep -p -b MB vfs.inodes.count -c /etc/pcp/pmrep/pmrep.conf :vmstat

Shouldn't pmrep use this default config file, and users can
modify/specify their own if they want to? This probably provides a
better initial experience and is more in line with other tools with a
config file.

If you're happy with this, lmk and I'll submit a patch.

Jamie

<Prev in Thread] Current Thread [Next in Thread>