pcp
[Top] [All Lists]

pcp updates: merges, fixes, qa

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: pcp updates: merges, fixes, qa
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 10 Feb 2016 00:38:30 -0500 (EST)
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <747527817.19888682.1455082567138.JavaMail.zimbra@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: VgBwxeOYau7LMQuPtE/C6ijJlU48MA==
Thread-topic: pcp updates: merges, fixes, qa
Changes committed to git://git.pcp.io/pcp.git master

Nathan Scott (11):
      docs: clarification to options handling on pcp sub-commands
      qa: allow qa/131 to handle remote-host-down more elegantly
      qa: update qa/667 to exercise latest pickle version via -r
      build: fix some perl xs unused-var compiler warnings
      qa: several fixes for test qa/370 (sar2pcp)
      pmdaproc: several fixes for test qa/370 (sar2pcp)
      pmdalinux: fix interrupts data types for big endian hosts
      pcp-vmstat: wrapper for pmstat to be more vmstat-alike
      qa: update test 1069 for latest round of pmrep tz updates
      qa: ensure all perfevent test files added into pcp-testsuite
      qa: remake perfevent qa/756 output for latest unit test additions

Hemant Kumar (3):
      pmdaperfevent: add extension for perf derived events
      qa: add unit tests for perfevent derived events
      docs: add syntax and other info to perfevent.conf.5 man page

Marko Myllynen (3):
      qa: mk.rep.sh updates to give better real-world metric coverage
      qa: new pmrep csv test - roundtrip testing (sheet2pcp <-> pmrep)
      pmrep: fix timezone handling/reporting

Mark Goodwin (2):
      pmiostat: support uninterpolated archive replay with -u flag
      qa: pmiostat additional testing in qa/1099 for new -u flag


 man/man1/pmstat.1                                           |   12 
 man/man5/perfevent.conf.5                                   |   19 
 qa/1069.out                                                 |    2 
 qa/1070                                                     |   56 ++
 qa/1070.map                                                 |   13 
 qa/1070.out                                                 |   45 ++
 qa/1099                                                     |   14 
 qa/1099.out                                                 |   16 
 qa/131                                                      |    4 
 qa/370                                                      |    9 
 qa/370.out.11                                               |    1 
 qa/667                                                      |   26 +
 qa/667.out                                                  |    3 
 qa/756.out                                                  |   11 
 qa/804                                                      |   28 +
 qa/804.out                                                  |   10 
 qa/archives/mk.rep.sh                                       |   44 +-
 qa/archives/mk.vmstat.sh                                    |   14 
 qa/archives/pcp-vmstat.0                                    |binary
 qa/archives/pcp-vmstat.index                                |binary
 qa/archives/pcp-vmstat.meta                                 |binary
 qa/archives/rep.0                                           |binary
 qa/archives/rep.index                                       |binary
 qa/archives/rep.meta                                        |binary
 qa/group                                                    |    2 
 qa/perfevent/GNUmakefile                                    |   15 
 qa/perfevent/config/test_derived_counters.txt               |   13 
 qa/perfevent/config/test_derived_counters_fail_mismatch.txt |   13 
 qa/perfevent/config/test_derived_counters_fail_missing.txt  |   13 
 qa/perfevent/perf_event_test.c                              |  122 +++++-
 src/pcp/GNUmakefile                                         |    3 
 src/pcp/atop/pcp-atop.1                                     |   23 -
 src/pcp/atop/pcp-atopsar.1                                  |   26 -
 src/pcp/dmcache/pcp-dmcache.1                               |    6 
 src/pcp/free/pcp-free.1                                     |    9 
 src/pcp/iostat/pcp-iostat.1                                 |   39 +-
 src/pcp/iostat/pcp-iostat.py                                |   25 +
 src/pcp/numastat/pcp-numastat.1                             |    6 
 src/pcp/uptime/pcp-uptime.1                                 |    6 
 src/pcp/verify/pcp-verify.1                                 |    2 
 src/pcp/vmstat/GNUmakefile                                  |   29 +
 src/pcp/vmstat/pcp-vmstat.sh                                |   60 +++
 src/perl/MMV/MMV.xs                                         |    8 
 src/pmdas/linux/help                                        |    2 
 src/pmdas/linux/interrupts.c                                |   17 
 src/pmdas/linux/pmda.c                                      |   16 
 src/pmdas/linux/proc_stat.c                                 |   22 +
 src/pmdas/linux/proc_stat.h                                 |    2 
 src/pmdas/linux/root_linux                                  |    2 
 src/pmdas/linux_proc/Install                                |    1 
 src/pmdas/perfevent/configparser.h                          |   12 
 src/pmdas/perfevent/configparser.l                          |  129 +++++-
 src/pmdas/perfevent/perfevent.conf                          |    5 
 src/pmdas/perfevent/perfinterface.c                         |  233 +++++++++++-
 src/pmdas/perfevent/perfinterface.h                         |   23 +
 src/pmdas/perfevent/perfmanager.c                           |    4 
 src/pmdas/perfevent/perfmanager.h                           |    2 
 src/pmdas/perfevent/pmda.c                                  |  104 ++++-
 src/pmdas/perfevent/pmns                                    |    4 
 src/pmlogconf/tools/vmstat                                  |    4 
 src/pmrep/pmrep.conf                                        |    4 
 src/pmrep/pmrep.py                                          |   40 +-
 62 files changed, 1189 insertions(+), 184 deletions(-)


commit 9365a88a4e4c8053debb72bb879a45205b1f2a17
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Feb 10 16:17:51 2016 +1100

    qa: remake perfevent qa/756 output for latest unit test additions

commit 6b615cbcb2b9ac1203253f6738695181028889f7
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Feb 10 16:09:34 2016 +1100

    qa: ensure all perfevent test files added into pcp-testsuite

commit 8d621a2f24a87e6f1a4930fb21b64ea74a4e70de
Author: Hemant Kumar <hemant@xxxxxxxxxxxxxxxxxx>
Date:   Wed Feb 10 16:00:25 2016 +1100

    docs: add syntax and other info to perfevent.conf.5 man page
    
    This adds the necessary information regarding the usage of derived
    perf events to perfevent.conf.5 man page.
    
    Signed-off-by: Hemant Kumar <hemant@xxxxxxxxxxxxxxxxxx>

commit 069223acdefdc5b21e382765e28040015560f7eb
Author: Hemant Kumar <hemant@xxxxxxxxxxxxxxxxxx>
Date:   Wed Feb 10 15:57:32 2016 +1100

    qa: add unit tests for perfevent derived events
    
    This commit adds unit tests for perf derived events.  The first test
    case is to check the number of the perf derived events.  Second case
    checks if there is a mismatch between the cpu configuration of the
    perf derived events' counters.  Final test case checks if there is a
    counter in derived list which is not enabled in the perfevent.conf
    base list.
    
    Signed-off-by: Hemant Kumar <hemant@xxxxxxxxxxxxxxxxxx>

commit c1a856f01a9433f1a037be4ab2c3f1fe6d79248d
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Wed Feb 10 15:54:57 2016 +1100

    qa: pmiostat additional testing in qa/1099 for new -u flag
    
    Testing pmiostat in non-interpolation mode

commit 476c3254cdc73d6cc5ad86ec6fab184ce97e08a7
Author: Hemant Kumar <hemant@xxxxxxxxxxxxxxxxxx>
Date:   Wed Feb 10 15:52:42 2016 +1100

    pmdaperfevent: add extension for perf derived events
    
    This gives the ability to the perfevent agent to export derived
    events.  Derived events are based on the hardware/perf counters.
    Users can now just say that a derived event is based on so-and-
    so basic counters.  The perfevent agent will find the value for
    the derived event - e.g., in perfevent.conf(5), we can say:
    
    [bandwidth:derived]
    snbep_unc_imc0::UNC_M_CAS_COUNT:RD node
    snbep_unc_imc0::UNC_M_CAS_COUNT:WR node
    snbep_unc_imc1::UNC_M_CAS_COUNT:RD node
    snbep_unc_imc1::UNC_M_CAS_COUNT:WR node
    snbep_unc_imc2::UNC_M_CAS_COUNT:RD node
    snbep_unc_imc2::UNC_M_CAS_COUNT:WR node
    snbep_unc_imc3::UNC_M_CAS_COUNT:RD node
    snbep_unc_imc3::UNC_M_CAS_COUNT:WR node
    
    And then the accumulated counters metric can be observed:
    
     # pmval perfevent.derived.bandwidth.value
    
    metric:    perfevent.derived.bandwidth.value
    host:      ....
    semantics: cumulative counter (converting to rate)
    units:     count (converting to count / sec)
    samples:   all
    
                  cpu0                  cpu8
                4.606E+06             1.303E+06
                4.590E+06             1.763E+06
    
    Signed-off-by: Hemant Kumar <hemant@xxxxxxxxxxxxxxxxxx>

commit 849f1d5d818a51eb778efd9039b0ccc264e3437b
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Feb 10 14:54:03 2016 +1100

    qa: update test 1069 for latest round of pmrep tz updates

commit 317408ae1958edaca16ce57fa83196ed46bd3794
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date:   Wed Feb 10 14:51:23 2016 +1100

    pmrep: fix timezone handling/reporting

commit 553d1822d454ddfa586263509f8736f9df92e7f7
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date:   Wed Feb 10 14:48:09 2016 +1100

    qa: new pmrep csv test - roundtrip testing (sheet2pcp <-> pmrep)

commit eb38d5039f49c386515a7743f43bc9dded06b429
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date:   Wed Feb 10 14:42:05 2016 +1100

    qa: mk.rep.sh updates to give better real-world metric coverage

commit aad4d15b693ce7444d9c393e733d4f74b0116f7f
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Feb 10 14:37:20 2016 +1100

    pmdalinux: fix interrupts data types for big endian hosts
    
    In the context of Red Hat BZ 1297822 MiloÅ discovered that
    big endian hosts were reporting zero for all interrupts
    metrics (courtesy of qa/886).  Turned out to be another of
    those mismatched 32/64-bit variable copies.  Auditing the
    kernel code confirms the currently-exported metric type is
    correct, it is the pmdalinux pmAtomValue copying at fault.

commit ab073dab4a71fd910d6ce2661032dc0a9d49f258
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Feb 10 14:23:26 2016 +1100

    pmdaproc: several fixes for test qa/370 (sar2pcp)
    
    Resolves several problems Lukas, MiloÅ and I have encountered
    in this test in the last couple of days -
    - loosen fuzzy matching for floating-point imprecision a bit;
    - handle an AM/PM failure Lukas observed on a buildbot, where
      bit-after-midnight values were reported as bit-after-noon.
    - the sar input data is currently all x86_64-specific, and so
      this test fails on other platforms like s390x, ppc, etc; in
      the short-term use _notrun to avoid this issue.  Over time,
      we need to add archives with arch-specific sar2pcp input.

commit ed41c4ae60c72d5cae1962d414ba5c2fa9ae5529
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Feb 10 14:18:34 2016 +1100

    qa: several fixes for test qa/370 (sar2pcp)
    
    Resolves several problems Lukas, Milos and I have encountered
    here in the last couple of days -
    - loosen fuzzy matching for floating-point imprecision a bit;
    - handle an AM/PM failure Lukas observed on a buildbot, where
      bit-after-midnight values were reported as bit-after-noon.
    - the sar input data is currently all x86_64-specific, and so
      this test fails on other platforms like s390x, ppc, etc; in
      the short-term use _notrun to avoid this issue.  Over time,
      we need to add archives with arch-specific sar2pcp input.

commit 0a1cda5d6c272d5fc189e14d8d9951564030fcc0
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Feb 10 14:03:57 2016 +1100

    build: fix some perl xs unused-var compiler warnings

commit 3531fe85db37a4ad5cb475c93d47d7dd59fb22c0
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Feb 10 14:03:11 2016 +1100

    qa: update qa/667 to exercise latest pickle version via -r
    
    Add regression testing for new pcp2graphite -r option from
    https://github.com/performancecopilot/pcp/pull/66

commit a421f21e10b4f22a7365b58903410a4f6b78cff7
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Feb 10 13:59:20 2016 +1100

    qa: allow qa/131 to handle remote-host-down more elegantly

commit c4993bce2ceeacef502ded7bc9e989606f23bddc
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Feb 10 13:58:31 2016 +1100

    docs: clarification to options handling on pcp sub-commands

commit 8c6d2be276f3ee7db303d7934abbbba5666a059e
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Wed Feb 10 13:38:56 2016 +1100

    pcp-vmstat: wrapper for pmstat to be more vmstat-alike
    
    Wrapper around pmstat to operate in a vmstat-alike way.
    Test qa/804 added to exercise the script.
    
    In the process found the use of proc_running & proc_blocked
    to be needed, which we were not exporting from /proc/stat;
    instead pmdaproc metrics were being used (which require a
    /proc/*/stat scan and associated process state accounting in
    the PMDA) for information the kernel already makes available
    more efficiently.  Added the missing metrics into pmdalinux,
    and start using them throughout.

commit d8fdf340a692d53ec530372c1df17981825351da
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Wed Feb 10 13:00:39 2016 +1100

    pmiostat: support uninterpolated archive replay with -u flag
    
    The -u flag disables interpolation when replaying an archive.
    Instead the native underlying replay interval in the archive
    is used. See the -u option in the man page for details.

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: merges, fixes, qa, Nathan Scott <=