Changes committed to git://git.pcp.io/pcp.git master
Marko Myllynen (2):
libvirt pmda: cosmetic update to connect script
libvirt pmda: add support for new perf metrics
Nathan Scott (1):
scripts: ensure correct tempfile handling used throughout
man/man3/pmda.3 | 10 +--
src/include/pcp.env | 13 +++-
src/pmcd/pmdaproc.sh | 97 +++++++++++++++++------------------
src/pmdas/libvirt/connect | 2
src/pmdas/libvirt/pmdalibvirt.python | 4 +
5 files changed, 70 insertions(+), 56 deletions(-)
commit a2a727b24388375f52b8aa7de5e74619d90fdb53
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Wed Oct 5 12:04:29 2016 +1100
libvirt pmda: add support for new perf metrics
Support new perf metrics from libvirt version 2.3:
https://libvirt.org/git/?p=libvirt.git;a=commit;h=bae660869de0612bee2a740083fb494c27e3f80c
commit f57656734ca1397e27312a0b6aa3da7ab4e0db9a
Author: Marko Myllynen <myllynen@xxxxxxxxxx>
Date: Wed Oct 5 12:01:18 2016 +1100
libvirt pmda: cosmetic update to connect script
commit faebf41be59418c7d829fd054048ff27cb5cd946
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Oct 5 11:37:46 2016 +1100
scripts: ensure correct tempfile handling used throughout
Auditing recent SElinux failure logs came across an accidental
regression from recent changes, where we've started using /tmp
directly in _get_pids_by_name rather than the tmpfile handling
of the calling script.
This is further complicated by pmdaproc.sh having some special
tmpfile handling ($__tmp instead of $tmp) which also conflicts
accidentally with same-named variable use in _get_pids_by_name.
So, this change makes _get_pids_by_name use the $tmp scheme of
the calling script. It also updates pmdaproc.sh to share this
same scheme (keeping $__tmp for Install/Remove back-compat).
The PMDA(3) man page is updated to reflect this, and to correct
the discussion of $__tmp (which was a directory even before the
change being made here, so some wording there was NQR).
It would be good to switch pcp/qa over to using mktemp rather
than its own scheme, but thats a much larger change. So, I've
put a little note in _get_pids_by_name to this affect, and we
allow it to continue to be called from QA (with a file prefix,
rather than a directory prefix for tmpfiles, IOW).
|