pcp
[Top] [All Lists]

pylint cleanup

To: Stan Cox <scox@xxxxxxxxxx>
Subject: pylint cleanup
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 24 Apr 2013 02:09:02 -0400 (EDT)
Cc: PCP <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <921922770.3037295.1366783319674.JavaMail.root@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: xA8xK7SbKr7n5LRuQeNsW0dWzfhBGQ==
Thread-topic: pylint cleanup
Hey Stan,

Noticed the disabling of "method could be a function" in that recent
update - another way to deal with that, without the hard-to-decipher
magic-pylint-override, is to change, e.g.:

    def get_total(self): 
        True    # pylint: disable-msg=W0104

to
    @staticmethod
    def get_total():
        True

At least, I found that worked for me where I needed similar.


Have pulled in all your code to my tree now.  Am thinking of attempting
a merge into dev soon, so been working through QA a bit (haven't done a
run with your code though) - any known QA issues there?

Also, I noticed Ken was attempting to assign a pmcollectl issue over to
you via oss bugzilla a day or two back - did you notice that one?  Looks
like another one of those pesky single-cpu-machine type issues.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>