Hey Frank,
"Frank Ch. Eigler" <fche@xxxxxxxxxx> writes:
[...]
> The effect of that patch would be not only to just disable auto-enable
> during the initial pmda install, but on every subsequent pmcd restart.
> That's harsh.
Admittedly that was a side effect I had not considered, and I would
agree it is undesirable.
>> The qa would need updating again, which I can provide. I would also
>> like to remove the phrasing that warnings are reasonable in the
>> testsuite, imo in this case, they aren't.
>
> The warnings in this case are apropos: some counter values are just
> not available for the asking. By turning auto-enable off during
> install, as in your patch, this fact is obscured from the
> pmprobe/user, because then no counters are even attempted to be used!
> If the point of the pmdaInstall "pmprobe -i" is to exercise the pmda,
> then let's exercise it.
While I understand the warnings themselves are apropos, my issue with
them was more along the lines of, how is a user discern between those
warnings, and legitimate ones? Perhaps a good compromise could be to
make mention/echo in the Install script (similar to pmdatrace),
mentioning to a user that this may happen.
>> On a side note, I'm not sure what the changes in pmdapapi.1 are
>> supposed to mean? Are they mistakes? "#true -- ..." ?
>
> They're just comments, explaining each command. They're executable,
> in case a user copy&pastes that section of the man page into a shell.
Ok.
Cheers,
Lukas
|