Re: [pcp] pcp updates: pmdajson counter metrics

[Lukas Berk <lberk@xxxxxxxxxx>]

Hi Nathan,

Nathan Scott <nathans@xxxxxxxxxx> writes:
[...]
> Looks good to me - thanks.  I think we'll need a README update
> (src/pmdas/json/README that is) to document the new keyword(s)
> too, and...

Thanks for reviewing, added this to the README.

[...]
> I suggest accepting "instantaneous" as a synonym for "instant"
> and we may as well support "discrete" while you are in there?

Sure, done.

> Also, if someone wants a counter-semantics string, I'd just
> let 'em (rather than silently dropping it) - we don't make a
> restriction like that in the C/python APIs, *shrug* - it'd be
> a pretty strange metric though.

Heh, ok, I've relaxed that.  I've pushed this commit and the relavent qa
change upstream.  Will send the updates email out later today.

Cheers,

Lukas