pcp
[Top] [All Lists]

Re: [pcp] pcp updates: build, pmdapapi, qa

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] pcp updates: build, pmdapapi, qa
From: Lukas Berk <lberk@xxxxxxxxxx>
Date: Tue, 09 Dec 2014 14:38:25 -0500
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <501165841.12943406.1418088614551.JavaMail.zimbra@xxxxxxxxxx> (Nathan Scott's message of "Mon, 8 Dec 2014 20:30:14 -0500 (EST)")
References: <87vbllyirx.fsf@xxxxxxxxxx> <501165841.12943406.1418088614551.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
Hey Nathan,

Nathan Scott <nathans@xxxxxxxxxx> writes:
[...]
>> Changes commited to git://sourceware.org/git/pcpfans.git lberk/dev
> I'm seeing a new build failure with these changes on older PAPIs...
>
> papi.c: In function 'papi_internal_init':
> papi.c:648: warning: statement with no effect
> papi.c:651: error: 'PAPI_component_info_t' has no member named 'disabled'
> papi.c:654: warning: implicit declaration of function 'PAPI_enum_cmp_event'

Ah, thanks for catching that.  As you pointed to on irc, adding an
autoconf check which triggers a macro definition should fix a sitation
like this.  I've added that in commit 3ba8c73256cfb7b3 on lberk/dev.

I've tested the build on a local RHEL6 vm and everything builds
smoothly.  Would you like another pcp updates email? or is noting the
commit here enough to merge?

Thanks,

Lukas

<Prev in Thread] Current Thread [Next in Thread>