Hey Frank,
"Frank Ch. Eigler" <fche@xxxxxxxxxx> writes:
> Please have a look over pcpfans.git fche/papi. If it looks generally
> acceptable, I'm ready to assist lberk in QA'ing the heck out of it.
Thanks for throwing this together. I like the idea of using the
timeout to ensure counters don't continue on for too long. The only nit
I have within the code itself; is there a chance you could give the
'auto_afid' variable a more descriptive name? or perhaps a comment to
the appropriate man page (I assume pmaf but it wasn't initially clear to
me).
If you would consider a few doc tweaks (patch attached) I'd appreciate
it. I'd be nice if the pminfo help text labled the units for a quick
glance without needing the man page. And I added the note that setting
papi.control.auto_enable to 0 disables the auto_enabling.
Other than that I'd be happy to start throwing together some relavent
qa.
Cheers,
Lukas
0001-Tweak-pmdapapi-docs.patch
Description: Text Data
|