Hey,
Nathan Scott <nathans@xxxxxxxxxx> writes:
[...]
> Its all merged, then I realised there may be a little issue. The man
> page reference uses "papi.system.perf.BRANCH-MISSES" as an example -
> is that a name that would actually come out of PAPI? (I assume so)
Yes, that's the name as reported by PAPI.
> The problem is, the hyphen there is not valid as part of a metric name.
> In some tools, like pmie, that symbol is a keyword in the language and
> is used to separate tokens (so the above would be parsed as "MISSES" &
> "papi.system.perf.BRANCH", with the subtraction token in-between).
Understood, thanks for catching this.
> The legal characters in metric names are described in pmns(5), in the
> "SYNTAX" section. I guess we'll need a mapping function to translate
> between the two forms (for events with invalid PMNS names, we'd need a
> way to replace hyphens with underscores, for example - not sure what
> other kinds of characters might appear in PAPI event names though).
Instead I opted to add that character to the possibilites of the
tokenizer and substitute a '.' (which aiui, is a valid pmns character).
I've commited the fix to lberk/dev, commit e44556032a, it also includes
the updated man page.
Cheers,
Lukas
|