Hi,
Ken McDonell <kenj@xxxxxxxxxxxxxxxx> writes:
> Note, this the the way I think optional components should be handled
> throughout the build and packaging scripts.
[...]
> Ken McDonell (17):
> configure, builddefs.in: additional optional build/package hooks
> pmdas: conditional build/packaging changes
> rpm spec file: changes for optionally built/packaged pmdas
> build/rpm/GNUmakefile: missed extra pmda_foo variables
[...]
If the configure script now has pmdaelasticsearch inclusion depending on
LWP::UserAgent, shouldn't we include that as a BuildRequires (not just a
Requires) in the spec file? In testing my spin-rawhide sources fix
today, it was failing due to pmdaelasticseach not being packaged, but
still attempting to be built as per the spec file. Perhaps as simple as
the attached patch?
Relevant koji output:
https://kojipkgs.fedoraproject.org//work/tasks/8503/11728503/build.log
Cheers,
Lukas
diff --git a/build/rpm/fedora.spec b/build/rpm/fedora.spec
index 7906e3f..97b4e6c 100644
--- a/build/rpm/fedora.spec
+++ b/build/rpm/fedora.spec
@@ -693,6 +693,7 @@ Group: Applications/System
Summary: Performance Co-Pilot (PCP) metrics for Elasticsearch
URL: http://www.pcp.io
Requires: perl-PCP-PMDA = %{version}-%{release}
+BuildRequires: perl(LWP::UserAgent)
Requires: perl(LWP::UserAgent)
%description pmda-elasticsearch
|