pcp
[Top] [All Lists]

Re: [pcp] PCP Updates: Fix Intermittent Failure of qa tests 712, 713, 71

To: Dave Brolley <brolley@xxxxxxxxxx>
Subject: Re: [pcp] PCP Updates: Fix Intermittent Failure of qa tests 712, 713, 714
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 25 Mar 2014 22:43:36 -0400 (EDT)
Cc: PCP Mailing List <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1102981313.459447.1395795004225.JavaMail.zimbra@xxxxxxxxxx>
References: <53319976.10107@xxxxxxxxxx> <1102981313.459447.1395795004225.JavaMail.zimbra@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: y5P2PP/oTW/t9qqrZHTcvHq+FDNRpeebht4L
Thread-topic: PCP Updates: Fix Intermittent Failure of qa tests 712, 713, 714
Hi Dave,

----- Original Message -----
> ----- Original Message -----
> > On the brolley/dev branch of pcpfans....
> > 
> 
> Seems OK to me (I've not observed this race though - different NSS
> libs/tools version perhaps).  That earlier qa/966 looks nicely put
> together too, just trying it out locally - thanks!
> 

One minor issue - the output has dependencies on the version of
coreutils installed (also unlikely to work cross-platform, if we
ever did secure socket builds somewhere else someday)...

diff 966.out 966.out.bad
14,15c14,15
< chmod: cannot access âCOLLECTORDB/*â: No such file or directory
< chown: cannot access âCOLLECTORDBâ: No such file or directory
---
> chmod: cannot access `COLLECTORDB/*': No such file or directory
> chown: cannot access `COLLECTORDB': No such file or directory

This is from common.secure I guess - when nss_setup_certificates
is skipped (the withcerts=false case).

Would ...

    if $withcerts
    then
        nss_setup_certificates $fqdn $host
        $sudo chmod -R 0644 $collectordb/*
        $sudo chown -R pcp:pcp $collectordb
    else
        echo "Skipping addition of certificates to certdb"
    fi

and remaking 966.out do the trick here?

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>