Hi,
A couple trivial changes caught by some static analysis. A full
testsuite run showed no regressions.
Changes committed to git://git.pcp.io/lberk/pcp.git master
Lukas Berk (3):
Remove unused for loop from interp.c
Adjust size variable to be signed size_t
Drop unused condition check
src/libpcp/src/interp.c | 22 ++++++++++------------
src/pmdas/linux/proc_partitions.c | 2 +-
src/pmdas/mmv/src/mmv.c | 2 +-
3 files changed, 12 insertions(+), 14 deletions(-)
Details ...
commit 2398ee8b05c242a6e9e9f58e33dbe4809b733e72
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Mon May 9 16:35:23 2016 -0400
Drop unused condition check
The 'item' variable in a __pmID_int struct is unsigned, so checking that
it's greater or equal to zero will never be false. Drop the check
commit f377687f170051feaa55e67ec9f4f3968638116a
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Mon May 9 16:34:18 2016 -0400
Adjust size variable to be signed size_t
'size' was being compared to a negative value for error checking. This
would never trigger being used as a 'size_t' as it's unsigned. Changing
to ssize_t accordingly.
commit 299c3c08f66b4c87fdeb8e11821efc14fca4aaf1
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Mon May 9 16:33:14 2016 -0400
Remove unused for loop from interp.c
The infinite for loop was no longer being used, either one of the two
conditions were hit, or we'd goto all_done. Clean up.
|