pcp
[Top] [All Lists]

Re: [pcp] Linux PMDA fd count metric

To: David Disseldorp <ddiss@xxxxxxx>
Subject: Re: [pcp] Linux PMDA fd count metric
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 26 Jul 2011 20:44:26 +1000 (EST)
Cc: pcp@xxxxxxxxxxx
In-reply-to: <1311587964-26531-1-git-send-email-ddiss@xxxxxxx>
----- Original Message -----
> Hi,
> 
> The following patch adds a proc.fd.count metric to the Linux PMDA,
> using the contents of /proc/<pid>/fd as its data source. This metric
> may be useful in watching for application file descriptor leaks.
> 
> Version 2:
> - Unconditionally count all /proc/<pid>/fd entries, then subtract two
> - rename metric from proc.fd.numopen
> 

Looks good to me David - I've re-reviewed, done some quick tests & merged
into the dev branch.  Nice work - I'm sure I will be using this - thanks!

cheers.

-- 
Nathan

<Prev in Thread] Current Thread [Next in Thread>