pcp
[Top] [All Lists]

Re: [pcp] Hotproc fixes

To: Martins Innus <minnus@xxxxxxxxxxx>, Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: [pcp] Hotproc fixes
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu, 30 Apr 2015 19:09:02 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <55422C85.7060307@xxxxxxxxxxx>
References: <5536A934.8040002@xxxxxxxxxxx> <5537A3F3.5060204@xxxxxxxxxxx> <233739221.5258413.1429764654377.JavaMail.zimbra@xxxxxxxxxx> <55392BAB.3060101@xxxxxxxxxxx> <806884984.5885784.1429839438565.JavaMail.zimbra@xxxxxxxxxx> <554128C1.8080901@xxxxxxxxxxx> <102929865.10042134.1430363515688.JavaMail.zimbra@xxxxxxxxxx> <55422C85.7060307@xxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: pA6RJ/K/zF6l7E+2ZX0Btem8JM4b0A==
Thread-topic: Hotproc fixes

----- Original Message -----
> Nathan,
> 
> On 4/29/2015 11:11 PM, Nathan Scott wrote:
> >> Also included some other cleanup suggestions from Marko, the ability to
> >> reload the config file, updated qa hopefully for all the changes, merged
> >> the manpage into procpmda, and added a new error code.  Feel free to
> >> drop that last one if you think its unnecessary. It should be its own
> >> commit.
> >>
> > I've left that last one for now - needs a bit more discussion I guess, as
> > an ABI extension.  I like it though.  We should probably audit the three/
> > four other PMDAs that already use PM_ERR_CONV and switch 'em over.
> 
> Sounds good.
> 
> >
> > Ken - any other thoughts on a specific error code for bad pmStore to a
> > PMDA?
> > (Oh, maybe the name PM_ERR_BADSTORE to match your error message more
> > closely
> > Martins?  the "FMT" part I found a little bit cryptic)
> I like yours better, I was struggling for a good name.

OK - if there's no objections, lets go ahead with it - do you want to do the
honours Martins?

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>