pcp
[Top] [All Lists]

Re: [pcp] Expected warnings et al on platforms without secure sockets

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: [pcp] Expected warnings et al on platforms without secure sockets
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 19 Mar 2013 17:07:35 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <5148C8F8.8060606@xxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Hi Ken,

----- Original Message -----
> I'm seeing messages like this when running QA
> 
> Warning: __pmConnectRestoreFlags: cannot restore flags
> fcntl(3,F_SETFL,0xffffff9b) failed: Bad file descriptor
> 
> and it may be related to platforms where pmconfig -L reports
> secure_sockets=false
> 
> If the warning is "expected" in this case, we probably should not
> emit it.  Otherwise I need to filter it out of the QA output, which
> would mask it in any cases where the warning was not expected ...
> unless I have conditional output based on secure_sockets=false or
> secure_sockets=true which seems overkill.
> 
> Comments? Thoughts?
> 

Something's gone wrong - the non-secure-sockets builds should be
very much how things were before the introduction of NSS code,
and we've never had this warning before.  If you can track it down
that would be awesome, else I'll take a look later today.

> As an aside, when secure_sockets=false builddefs contains:
> NSSCFLAGS = -I
> NSPRCFLAGS = -I
> 
> which just does not look right (shouldn't these be empty?).
> 

Yep, that's wrong too - thanks, that thinko was definitely one of
mine, will fix it shortly.  :)

I am planning a 3.7.1 asap (today even, ideally) to roll up those
3.7.0 fixes from working with the Aconex operations folks - I'll
roll these couple in too.  Also, I was adding code yesterday that
needed to treat the postinst scripts similarly to the way you had
tackled preinst before - if you could double check that stuff for
me it'd be much appreciated (in dev branch now).

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>